From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5621 invoked by alias); 8 Oct 2003 21:37:23 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 5614 invoked from network); 8 Oct 2003 21:37:23 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sources.redhat.com with SMTP; 8 Oct 2003 21:37:23 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 29025) id 7643B4C0319; Wed, 8 Oct 2003 23:37:22 +0200 (CEST) Date: Wed, 08 Oct 2003 21:37:00 -0000 From: Zdenek Dvorak To: Geoff Keating Cc: "gcc@gcc.gnu.org" Subject: Re: [tree-ssa] Garbage collector x bb annotations Message-ID: <20031008213722.GA22848@atrey.karlin.mff.cuni.cz> References: <20031006223141.GA2094@atrey.karlin.mff.cuni.cz> <1065619632.7057.44.camel@frodo.toronto.redhat.com> <20031008135344.GB18809@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-SW-Source: 2003-10/txt/msg00296.txt.bz2 Hello, > > > > I have just run into the following problem: dom_children get released by > > > > ggc_collect call in tree-ssa-pre. Allocating them by ggc seems wrong to > > > > me, since basic block annotations are allocated from obstack and > > > > invisible to garbage collector. > > > > > > > Yeah. But there's more than that, unfortunately. All the fields in > > > struct bb_ann_d are ggc allocated. The real solution would be to > > > finally convert basic blocks to ggc. Volunteers? > > > > I may try (I need it anyway for tree-ssa-cfg branch). The whole issue > > is however quite ugly as this combines basically all allocation > > mechanisms that are available in gcc (basic blocks themselves are pool > > allocated). > > It's not that ugly to make the fix, you simply have to throw out all > those other allocation mechanisms and use ggc. that's not really a good idea. Their purpose is to improve data locality, and changing this would slow down things. Zdenek