public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Henderson <rth@redhat.com>,
	law@redhat.com, Jan Hubicka <hubicka@ucw.cz>,
	Jan Hubicka <jh@suse.cz>,
	gcc@gcc.gnu.org
Subject: Re: Tree-SSA self checking infrastructure
Date: Wed, 19 Nov 2003 21:34:00 -0000	[thread overview]
Message-ID: <20031119212348.GU16923@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20031119210127.GB31811@redhat.com>

> On Wed, Nov 19, 2003 at 12:13:06PM -0700, law@redhat.com wrote:
> >  >This brings me into questions about my tail call updating code.
> >  >Perhaps I need to re-do SSA form on call cobbered variables after
> >  >removing the call?
> > Are you changing the CFG?  Are you changing the dominator tree?  Those
> > are the key questions.
> 
> Yes, he is, but only by adding a new block on the ENTRY->BB0 edge,
> and then edges into that block from the tail recursion sites.
> 
> I may be mistaken, but I thought the new phi nodes he was adding 
> there would be correct.  Perhaps this is a good test for a verify_ssa
> pass?
Actually good motivation to write it.
However I didn't find anythign wrong about it, just double checking
everything.

The problem appears to be must_alias related.  If I do tailcall/tail
recursion before it, everything works, after it it breaks, but of course
disabling must_alias may alter decisions of later passes.
I've collected several fixes to must_alias/tree-dfa and I re-testing now
so perhaps the bug will just go away....

Honza
> 
> 
> r~

  reply	other threads:[~2003-11-19 21:23 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-19 18:38 Jan Hubicka
2003-11-19 18:43 ` law
2003-11-19 18:48   ` Andrew MacLeod
2003-11-19 18:56     ` Jan Hubicka
2003-11-19 19:04       ` Andrew MacLeod
2003-11-19 19:39         ` law
2003-11-19 19:01     ` law
2003-11-19 19:12       ` Andrew MacLeod
2003-11-19 20:16         ` law
2003-11-19 18:51   ` Jan Hubicka
2003-11-19 19:09     ` law
2003-11-19 19:14       ` Jan Hubicka
2003-11-19 19:47         ` law
2003-11-19 20:23           ` Andrew MacLeod
2003-11-19 20:29             ` Andrew MacLeod
2003-11-19 20:36             ` Andrew MacLeod
2003-11-19 20:40               ` Andrew MacLeod
2003-11-19 22:12                 ` Andrew MacLeod
2003-11-19 22:46                   ` law
2003-11-19 22:59                 ` law
2003-11-19 20:47           ` Jan Hubicka
2003-11-19 21:13             ` law
2003-11-19 21:18               ` Jan Hubicka
2003-11-19 21:45                 ` law
2003-11-19 21:49                   ` Andrew MacLeod
2003-11-19 21:23           ` Richard Henderson
2003-11-19 21:34             ` Jan Hubicka [this message]
2003-11-19 21:44             ` law
2003-11-19 21:45               ` Jan Hubicka
2003-11-19 21:51                 ` law
2003-11-19 22:13                   ` Andrew MacLeod
2003-11-20  0:14                     ` Diego Novillo
2003-11-19 22:15                   ` Jan Hubicka
2003-11-19 22:56                     ` law
2003-11-19 21:58               ` Richard Henderson
2003-11-19 19:34       ` Jan Hubicka
2003-11-19 20:02         ` law
2003-11-19 20:49           ` Jan Hubicka
2003-11-19 21:01             ` law
2003-11-19 21:22               ` Jan Hubicka
2003-11-19 21:28             ` Richard Henderson
2003-11-21  6:35   ` Jan Hubicka
2003-11-21  8:10     ` law
2003-11-21 12:31       ` Jan Hubicka
2003-11-19 19:06 ` Richard Henderson
2003-11-19 19:09   ` Jan Hubicka
2003-11-19 21:36     ` Richard Henderson
2003-11-19 21:45       ` Jan Hubicka
2003-11-19 21:47         ` Richard Henderson
2003-11-19 22:23         ` Tree sharing issues Jan Hubicka
2003-11-19 22:27           ` law
2003-11-19 22:31             ` Jan Hubicka
2003-11-19 22:50               ` law
2003-11-19 23:02                 ` Jan Hubicka
2003-11-19 23:02                   ` law
2003-11-19 23:08                     ` Jan Hubicka
2003-11-19 23:12                       ` law
2003-11-19 23:20                         ` Jan Hubicka
2003-11-19 23:23                           ` law
2003-11-19 23:27                             ` Jan Hubicka
2003-11-19 23:30                               ` Richard Henderson
2003-11-20  0:33                                 ` Diego Novillo
2003-11-20  0:34                                   ` Jan Hubicka
2003-11-20  0:46                                     ` Diego Novillo
2003-11-20  4:22                                       ` law
2003-11-20  6:17                                         ` Diego Novillo
2003-11-19 23:33                               ` law
2003-11-19 23:34                                 ` Richard Henderson
2003-11-20  0:02                                   ` Jan Hubicka
2003-11-19 23:46                                 ` Jan Hubicka
2003-11-20 18:38                                   ` law
2003-11-20  0:37                               ` Diego Novillo
2003-11-20  0:41                                 ` Jan Hubicka
2003-11-20  1:26                                 ` Jan Hubicka
2003-11-20  0:20                   ` Diego Novillo
2003-11-20  0:29                     ` Jan Hubicka
2003-11-20  0:55                       ` Diego Novillo
2003-11-20  0:15         ` Tree-SSA self checking infrastructure Diego Novillo
2003-11-20  0:21           ` Jan Hubicka
2003-11-20  9:31             ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031119212348.GU16923@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc@gcc.gnu.org \
    --cc=jh@suse.cz \
    --cc=law@redhat.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).