sparc-sun-solaris2.9 bootstrap broken due to final.c change

sparc-sun-solaris2.9 bootstrap broken due to final.c change

[Gerald Pfeifer]

I'm afraid this change

2004-01-17  Daniel Jacobowitz  <drow@mvista.com>

        * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define.
        (final_scan_insn): Update to take an additional SEEN argument.  Emit
        a line note after the prologue.  Make static.
        (line_note_exists): Remove.
        (final): Don't initialize line_note_exists.  Update call to
        final_scan_insn.
        * output.h (final_scan_insn): Remove prologue.
        * function.c (set_insn_locators): Update comment.
        (thread_prologue_and_epilogue_insns): Add a comment.

is causing bootstrap to fail on sparc-sun-solaris2.9:

  ranlib libbackend.a
  gcc   -g  -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long    -DHAVE_CONFIG_H  -o cc1 \
        c-parse.o c-lang.o c-pretty-print.o stub-objc.o attribs.o c-errors.o c-lex.o c-pragma.o c-decl.o c-typeck.o c-convert.o c-aux-info.o c-common.o c-opts.o
        c-format.o c-semantics.o c-incpath.o cppdefault.o c-ppoutput.o
        c-cppbuiltin.o prefix.o c-objc-common.o c-dump.o c-pch.o libcpp.a  main.o libbackend.a
        ../libiberty/libiberty.a ../intl/libintl.a
  Undefined                       first referenced
   symbol                             in file
  final_scan_insn                     libbackend.a(sparc.o)
  ld: fatal: Symbol referencing errors. No output written to cc1
  collect2: ld returned 1 exit status
  gmake[2]: *** [cc1] Error 1

Gerald
-- 
Gerald Pfeifer (Jerry)   gerald@pfeifer.com   http://www.pfeifer.com/gerald/

Re: sparc-sun-solaris2.9 bootstrap broken due to final.c change

[Andreas Tobler]

Gerald Pfeifer wrote:

> I'm afraid this change
> 
> 2004-01-17  Daniel Jacobowitz  <drow@mvista.com>
> 
>         * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define.
>         (final_scan_insn): Update to take an additional SEEN argument.  Emit
>         a line note after the prologue.  Make static.
>         (line_note_exists): Remove.
>         (final): Don't initialize line_note_exists.  Update call to
>         final_scan_insn.
>         * output.h (final_scan_insn): Remove prologue.
>         * function.c (set_insn_locators): Update comment.
>         (thread_prologue_and_epilogue_insns): Add a comment.
> 
> is causing bootstrap to fail on sparc-sun-solaris2.9:

his follow up patch works:

http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01749.html

A

Re: sparc-sun-solaris2.9 bootstrap broken due to final.c change

[Daniel Jacobowitz]

On Sun, Jan 18, 2004 at 07:09:01PM +0100, Andreas Tobler wrote:
> Gerald Pfeifer wrote:
> 
> >I'm afraid this change
> >
> >2004-01-17  Daniel Jacobowitz  <drow@mvista.com>
> >
> >        * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define.
> >        (final_scan_insn): Update to take an additional SEEN argument.  
> >        Emit
> >        a line note after the prologue.  Make static.
> >        (line_note_exists): Remove.
> >        (final): Don't initialize line_note_exists.  Update call to
> >        final_scan_insn.
> >        * output.h (final_scan_insn): Remove prologue.
> >        * function.c (set_insn_locators): Update comment.
> >        (thread_prologue_and_epilogue_insns): Add a comment.
> >
> >is causing bootstrap to fail on sparc-sun-solaris2.9:
> 
> his follow up patch works:
> 
> http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01749.html

If someone would approve it...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: sparc-sun-solaris2.9 bootstrap broken due to final.c change

[Roger Sayle]

On Sun, 18 Jan 2004, Daniel Jacobowitz wrote:
> On Sun, Jan 18, 2004 at 07:09:01PM +0100, Andreas Tobler wrote:
> > Gerald Pfeifer wrote:
> >
> > >I'm afraid this change
> > >
> > >2004-01-17  Daniel Jacobowitz  <drow@mvista.com>
> > >
> > >        * final.c (SEEN_BB, SEEN_NOTE, SEEN_EMITTED): Define.
> > >        (final_scan_insn): Update to take an additional SEEN argument.
> > >        Emit
> > >        a line note after the prologue.  Make static.
> > >        (line_note_exists): Remove.
> > >        (final): Don't initialize line_note_exists.  Update call to
> > >        final_scan_insn.
> > >        * output.h (final_scan_insn): Remove prologue.
> > >        * function.c (set_insn_locators): Update comment.
> > >        (thread_prologue_and_epilogue_insns): Add a comment.
> > >
> > >is causing bootstrap to fail on sparc-sun-solaris2.9:
> >
> > his follow up patch works:
> >
> > http://gcc.gnu.org/ml/gcc-patches/2004-01/msg01749.html
>
> If someone would approve it...

Sure.  This patch is Ok for whereever its required.

Roger
--