public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Mark Mitchell <mark@codesourcery.com>
Cc: Richard Guenther <rguenth@tat.physik.uni-tuebingen.de>, gcc@gcc.gnu.org
Subject: Re: RFC: cache uses_template_parms in tree node?
Date: Thu, 22 Jan 2004 17:00:00 -0000	[thread overview]
Message-ID: <20040122165810.GD8219@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <400FF7C4.50003@codesourcery.com>

> Richard Guenther wrote:
> 
> >Hi!
> >
> >To address the for_each_template_parm() performance problem, would it be
> >possible to cache the outcome of uses_template_parms() in the tree
> >node? Or would this caching somehow be invalidated later?
> 
> The right approach, as I've said before, is simply not to *use* 
> for_each_template_parm.
> 
> It should be unncessary; the right approach should be to use 
> type_dependent_p and its friends.
> 
> That's not a trivial change, but it's the right change.

Mark,
do you think such a change is possible for 3.4 GCC?  If not what would
you recommend to do for the release branch?  The for_each_template_parm
seems to be really one of the major CPU cycle consumers when it come to
C++ compilation and it would be shame to leave it that way for the
release.

Honza
> 
> There might be a very few places where for_each_template_parm would 
> still be necessary -- but they will not be anything that should up on 
> the profile.
> 
> -- 
> Mark Mitchell
> CodeSourcery, LLC
> mark@codesourcery.com

  reply	other threads:[~2004-01-22 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-22 11:22 Richard Guenther
2004-01-22 13:24 ` Giovanni Bajo
2004-01-22 13:41   ` Richard Guenther
2004-01-22 15:32     ` Giovanni Bajo
2004-01-22 16:18 ` RFC: " Gabriel Dos Reis
2004-01-22 16:23 ` Mark Mitchell
2004-01-22 17:00   ` Jan Hubicka [this message]
2004-01-22 17:02     ` Mark Mitchell
2004-01-24  2:29     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040122165810.GD8219@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=rguenth@tat.physik.uni-tuebingen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).