Re: fixing vs WARN_CFLAGS vs cross builds

[DJ Delorie <dj@redhat.com>]

> The gcc Makefile does not directly call "gcc" anywhere.  From a brief 
> glance, I think you mean CC_FOR_BUILD, which you have set to gcc.

Yes.

> It isn't exactly clear why you have a problem though.  WARN_CFLAGS is 
> set for a stage1 build only if the build (host?) compiler is gcc, and 
> your compiler is gcc, so why is there a problem?  Is there a particular 
> option which is the problem?  If so, which one?  Is this a versioning 
> problem?  I.e. an option is in WARN_CFLAGS that is not supported by an 
> old gcc version you are using for the bootstrap?

Yes.  BUILD_CC is 3.2.3, and does not support these:

cc1: unrecognized option `-Wno-variadic-macros'
cc1: unrecognized option `-Wold-style-definition'

> It may be reasonable to remove the WARN_CFLAGS setting in the fixinc.sh 
> rule.  We don't use WARN_CFLAGS anyplace else where we use CC_FOR_BUILD. 
>   This can work in stage2 etc builds, but this is probably not important 
> enough to worry about.
> 
> It would be nice to have a proper bug report though.

I was still trying to figure out what was supposed to happen from a
theoretical standpoint.  

I have a patch which tests for build!=host and disables WARN_CFLAGS,
but should fixinc *ever* be built with WARN_CFLAGS?