From: Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
To: gcc@gcc.gnu.org
Subject: [tree-ssa] Kills by VDEFs in mark_def_sites
Date: Wed, 14 Apr 2004 22:04:00 -0000 [thread overview]
Message-ID: <20040414213604.GA32480@atrey.karlin.mff.cuni.cz> (raw)
Hello,
a comment in tree-into-ssa.c:mark_def_sites states that
/* Note that virtual definitions are irrelevant for computing KILLS
because a VDEF does not constitute a killing definition of the
variable. */
and indeed, we do not set a bit in "kills" bitmap for VDEFs.
There are two things that make this part of code a bit weird:
1) For operand of VDEF and for VUSE we test whether the bit is set
in the "kills" bitmap; however this is clearly useless, as there
is no way how there could be anything set in this bitmap for virtual
operands.
2) The comment above is moreorless useless as well. Even if we set the
bit in the "kills" bitmap, everything would work exactly the same
way, since VDEF has an operand that is processed before the VDEF's
result, so the basic block processed would be marked in the livein
bitmap as well.
Are these observations correct, or am I missing something?
Zdenek
next reply other threads:[~2004-04-14 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 22:04 Zdenek Dvorak [this message]
2004-04-30 22:55 ` law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040414213604.GA32480@atrey.karlin.mff.cuni.cz \
--to=rakdver@atrey.karlin.mff.cuni.cz \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).