Newly failing fortran compilations in test-suite.

Newly failing fortran compilations in test-suite.

[Toon Moene]

There are a few recent failures in the fortran testsuite on, e.g., 
powerpc-unknown-linux-gnu:

FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O0
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O1
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O2
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O3 -fomit-frame-pointer
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-loops
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-all-loops 
-finline-functions
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -O3 -g
FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,  -Os
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O0
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O1
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O2
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O3 -fomit-frame-pointer
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-loops
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-all-loops 
-finline-functions
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -O3 -g
FAIL: gfortran.fortran-torture/execute/intrinsic_nearest.f90 
compilation,  -Os
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O0
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O1
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O2
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O3 -fomit-frame-pointer
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-loops
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O3 -fomit-frame-pointer -funroll-all-loops 
-finline-functions
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -O3 -g
FAIL: gfortran.fortran-torture/execute/intrinsic_set_exponent.f90 
compilation,  -Os
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O0
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O1
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O2
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O3 
-fomit-frame-pointer
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O3 
-fomit-frame-pointer -funroll-loops
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O3 
-fomit-frame-pointer -funroll-all-loops -finline-functions
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -O3 -g
FAIL: gfortran.fortran-torture/execute/nan_inf_fmt.f90 compilation,  -Os

that don't seem to fail on i686-pc-linux-gnu.

They all have a corresponding .x file with the content:

lappend additional_flags [ieee-options]
return 0

Will this work for all architectures ?

-- 
Toon Moene - e-mail: toon@moene.indiv.nluug.nl - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
Maintainer, GNU Fortran 77: http://gcc.gnu.org/onlinedocs/g77_news.html
A maintainer of GNU Fortran 95: http://gcc.gnu.org/fortran/

Re: Newly failing fortran compilations in test-suite.

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Saturday 11 September 2004 12:43, Toon Moene wrote:
> There are a few recent failures in the fortran testsuite on, e.g.,
> powerpc-unknown-linux-gnu:
>
> FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90
> compilation,  -O0

This is strange, it fails on x86-64 with:
Executing on host: /builds/gcc/misc/gcc/testsuite/../gfortran 
-B/builds/gcc/misc/gcc/testsuite/../ /cvs/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90  
-w  -O0  {}  -L/builds/gcc/misc/x86_64-suse-linux-gnu/32/libgfortran/.libs 
-L/builds/gcc/misc/x86_64-suse-linux-gnu/32/libiberty  -lm   -m32 
-o /builds/gcc/misc/gcc/testsuite/intrinsic_fraction_exponent.x    (timeout = 
300)
gfortran: : No such file or directory
compiler exited with status 1
output is:
gfortran: : No such file or directory

FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90 
compilation,
 -O0


The problem is the '{}' above.  Where does it come from?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Newly failing fortran compilations in test-suite.

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 2128 bytes --]

On Saturday 11 September 2004 12:48, Andreas Jaeger wrote:
> On Saturday 11 September 2004 12:43, Toon Moene wrote:
> > There are a few recent failures in the fortran testsuite on, e.g.,
> > powerpc-unknown-linux-gnu:
> >
> > FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90
> > compilation,  -O0
>
> This is strange, it fails on x86-64 with:
> Executing on host: /builds/gcc/misc/gcc/testsuite/../gfortran
> -B/builds/gcc/misc/gcc/testsuite/../
> /cvs/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_fraction_
>exponent.f90 -w  -O0  {} 
> -L/builds/gcc/misc/x86_64-suse-linux-gnu/32/libgfortran/.libs
> -L/builds/gcc/misc/x86_64-suse-linux-gnu/32/libiberty  -lm   -m32
> -o /builds/gcc/misc/gcc/testsuite/intrinsic_fraction_exponent.x    (timeout
> = 300)
> gfortran: : No such file or directory
> compiler exited with status 1
> output is:
> gfortran: : No such file or directory
>
> FAIL: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.f90
> compilation,
>  -O0
>
>
> The problem is the '{}' above.  Where does it come from?

I'm testing the following patch for the testsuite now.

Andreas

2004-09-11  Andreas Jaeger  <aj@suse.de>

 * lib/fortran-torture.exp (ieee-options): Add default return value.

============================================================
Index: gcc/testsuite/lib/fortran-torture.exp
--- lib/fortran-torture.exp 30 Aug 2004 12:13:37 -0000 1.5
+++ lib/fortran-torture.exp 11 Sep 2004 10:50:41 -0000
@@ -1,4 +1,4 @@
-# Copyright (C) 2003 Free Software Foundation, Inc.
+# Copyright (C) 2003, 2004 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -362,4 +362,5 @@ proc ieee-options { } {
          || [istarget "sh*-*-*"] } then {
       return "-mieee"
     }
+    return ""
 }

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Newly failing fortran compilations in test-suite.

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Saturday 11 September 2004 12:52, Andreas Jaeger wrote:
> On Saturday 11 September 2004 12:48, Andreas Jaeger wrote:
> [...]
> > The problem is the '{}' above.  Where does it come from?
>
> I'm testing the following patch for the testsuite now.

Won't make a difference for me.  So, how is this supposed to work?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Newly failing fortran compilations in test-suite.

[David Edelsohn]

>>>>> Andreas Jaeger writes:

>> > The problem is the '{}' above.  Where does it come from?
>> 
>> I'm testing the following patch for the testsuite now.

Andreas> Won't make a difference for me.  So, how is this supposed to work?

	I don't know either.  I tried the same fix and it did not work for
PowerPC; rth didn't have any ideas.

	I have been running with lib/fortran-torture.exp modified so that
it does not append additional_flags to options.

David

Re: Newly failing fortran compilations in test-suite.

[Andreas Jaeger]

On Sat, Sep 11, 2004 at 01:20:50PM -0400, David Edelsohn wrote:
> >>>>> Andreas Jaeger writes:
> 
> >> > The problem is the '{}' above.  Where does it come from?
> >> 
> >> I'm testing the following patch for the testsuite now.
> 
> Andreas> Won't make a difference for me.  So, how is this supposed to work?
> 
> 	I don't know either.  I tried the same fix and it did not work for
> PowerPC; rth didn't have any ideas.
> 
> 	I have been running with lib/fortran-torture.exp modified so that
> it does not append additional_flags to options.

We should get this fixed so that it works for everybody.  HAve you created
a bugzilla report for this already?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 N�rnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Re: Newly failing fortran compilations in test-suite.

[David Edelsohn]

>>>>> Andreas Jaeger writes:

Andreas> We should get this fixed so that it works for everybody.  HAve you created
Andreas> a bugzilla report for this already?

	No Bugzilla report yet.  I'm not even sure what Component to use.
"other"?

David

Re: Newly failing fortran compilations in test-suite.

[Richard Henderson]

Try this.


r~



Index: gfortran.fortran-torture/execute/intrinsic_fraction_exponent.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_fraction_exponent.x,v
retrieving revision 1.1
diff -c -p -d -u -r1.1 intrinsic_fraction_exponent.x
--- gfortran.fortran-torture/execute/intrinsic_fraction_exponent.x	30 Aug 2004 12:13:36 -0000	1.1
+++ gfortran.fortran-torture/execute/intrinsic_fraction_exponent.x	11 Sep 2004 18:50:24 -0000
@@ -1,2 +1,2 @@
-lappend additional_flags [ieee-options]
+add-ieee-options
 return 0
Index: gfortran.fortran-torture/execute/intrinsic_nearest.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_nearest.x,v
retrieving revision 1.1
diff -c -p -d -u -r1.1 intrinsic_nearest.x
--- gfortran.fortran-torture/execute/intrinsic_nearest.x	30 Aug 2004 12:13:36 -0000	1.1
+++ gfortran.fortran-torture/execute/intrinsic_nearest.x	11 Sep 2004 18:50:24 -0000
@@ -1,2 +1,2 @@
-lappend additional_flags [ieee-options]
+add-ieee-options
 return 0
Index: gfortran.fortran-torture/execute/intrinsic_set_exponent.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gfortran.fortran-torture/execute/intrinsic_set_exponent.x,v
retrieving revision 1.1
diff -c -p -d -u -r1.1 intrinsic_set_exponent.x
--- gfortran.fortran-torture/execute/intrinsic_set_exponent.x	30 Aug 2004 12:13:36 -0000	1.1
+++ gfortran.fortran-torture/execute/intrinsic_set_exponent.x	11 Sep 2004 18:50:24 -0000
@@ -1,2 +1,2 @@
-lappend additional_flags [ieee-options]
+add-ieee-options
 return 0
Index: gfortran.fortran-torture/execute/nan_inf_fmt.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/gfortran.fortran-torture/execute/nan_inf_fmt.x,v
retrieving revision 1.1
diff -c -p -d -u -r1.1 nan_inf_fmt.x
--- gfortran.fortran-torture/execute/nan_inf_fmt.x	30 Aug 2004 12:13:36 -0000	1.1
+++ gfortran.fortran-torture/execute/nan_inf_fmt.x	11 Sep 2004 18:50:24 -0000
@@ -1,2 +1,2 @@
-lappend additional_flags [ieee-options]
+add-ieee-options
 return 0
Index: lib/fortran-torture.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/fortran-torture.exp,v
retrieving revision 1.5
diff -c -p -d -u -r1.5 fortran-torture.exp
--- lib/fortran-torture.exp	30 Aug 2004 12:13:37 -0000	1.5
+++ lib/fortran-torture.exp	11 Sep 2004 18:50:24 -0000
@@ -346,20 +346,18 @@ proc fortran-torture { args } {
 }
 
 #
-# ieee-options -- return options necessary for 100% ieee conformance.
+# add-ieee-options -- add options necessary for 100% ieee conformance.
 #
-proc ieee-options { } {
+proc add-ieee-options { } {
     # Ensure that excess precision does not cause problems.
-    if [istarget "i?86-*-*"] then {
-      return "-ffloat-store"
-    }
-    if [istarget "m68k-*-*"] then {
-      return "-ffloat-store"
+    if { [istarget "i?86-*-*"]
+	 || [istarget "m68k-*-*"] } then {
+      uplevel 1 lappend additional_flags "-ffloat-store"
     }
-                                                                                
+
     # Enable full IEEE compliance mode.
     if { [istarget "alpha*-*-*"]
          || [istarget "sh*-*-*"] } then {
-      return "-mieee"
+      uplevel 1 lappend additional_flags "-mieee"
     }
 }

Re: Newly failing fortran compilations in test-suite.

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Richard Henderson <rth@redhat.com> writes:

> Try this.

Works for me on Linux/x86-64.

thanks,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]