* trunk broken for `make check'
@ 2004-11-19 12:38 Karel Gardas
2004-11-19 12:56 ` Eric Botcazou
0 siblings, 1 reply; 3+ messages in thread
From: Karel Gardas @ 2004-11-19 12:38 UTC (permalink / raw)
To: GCC Mailing List
Hello,
probably I have overseen something, but I would like to test yesterday's
main-line but it fails with:
thinkpad:/mnt/karel/gcc-main/obj$ make check
make[1]: Entering directory `/mnt/karel/gcc-main/obj/fixincludes'
autogen -T ../../gcc-main/fixincludes/check.tpl
../../gcc-main/fixincludes/inclhack.def
make[1]: autogen: Command not found
make[1]: *** [check] Error 127
make[1]: Leaving directory `/mnt/karel/gcc-main/obj/fixincludes'
make: *** [check-fixincludes] Error 2
thinkpad:/mnt/karel/gcc-main/obj$
The platform is Debian GNU/Linux 3.0, FSF binutils 2.14, gcc3.4.2 used to
bootstrap.
What have I done wrong?
Thanks,
Karel
--
Karel Gardas kgardas@objectsecurity.com
ObjectSecurity Ltd. http://www.objectsecurity.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: trunk broken for `make check'
2004-11-19 12:38 trunk broken for `make check' Karel Gardas
@ 2004-11-19 12:56 ` Eric Botcazou
2004-11-19 16:20 ` [PATCH] " Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Eric Botcazou @ 2004-11-19 12:56 UTC (permalink / raw)
To: Karel Gardas; +Cc: gcc
> probably I have overseen something, but I would like to test yesterday's
> main-line but it fails with:
>
> thinkpad:/mnt/karel/gcc-main/obj$ make check
> make[1]: Entering directory `/mnt/karel/gcc-main/obj/fixincludes'
> autogen -T ../../gcc-main/fixincludes/check.tpl
> ../../gcc-main/fixincludes/inclhack.def
> make[1]: autogen: Command not found
> make[1]: *** [check] Error 127
> make[1]: Leaving directory `/mnt/karel/gcc-main/obj/fixincludes'
> make: *** [check-fixincludes] Error 2
> thinkpad:/mnt/karel/gcc-main/obj$
>
> The platform is Debian GNU/Linux 3.0, FSF binutils 2.14, gcc3.4.2 used to
> bootstrap.
>
> What have I done wrong?
You need autogen to check fixincludes (fixincludes was just moved to
toplevel). Personally I always run 'make -k check' as prescribed in
http://gcc.gnu.org/install/test.html, which works around the problem.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] trunk broken for `make check'
2004-11-19 12:56 ` Eric Botcazou
@ 2004-11-19 16:20 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2004-11-19 16:20 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
>>The platform is Debian GNU/Linux 3.0, FSF binutils 2.14, gcc3.4.2 used to
>>bootstrap.
>>
>>What have I done wrong?
>
> You need autogen to check fixincludes (fixincludes was just moved to
> toplevel).
The problem arose when it was made a host module. Build modules are not
tested, so this bug is not directly related to moving fixincludes to the
toplevel: moving fixincludes to the toplevel kept the old behavior of
only running the fixincludes testsuite on explicit demand.
> Personally I always run 'make -k check' as prescribed in
> http://gcc.gnu.org/install/test.html, which works around the problem.
Also, not typing "make -k check" will for example cause almost always
the libjava tests not to run, because boehm-gc's tests exit with a 1 status.
The real fix is to change the toplevel to always behave like make -k,
see the attached patch.
Paolo
2004-11-18 Paolo Bonzini <bonzini@gnu.org>
* Makefile.tpl (check-[+module+], check-target-[+module+],
check-gcc-c++): Do not fail on errors.
* Makefile.in: Regenerate.
[-- Attachment #2: makefile-force-make-k-check.patch --]
[-- Type: text/plain, Size: 1744 bytes --]
Index: Makefile.tpl
===================================================================
RCS file: /cvs/gcc/gcc/Makefile.tpl,v
retrieving revision 1.117
diff -u -r1.117 Makefile.tpl
--- Makefile.tpl 13 Nov 2004 07:32:47 -0000 1.117
+++ Makefile.tpl 19 Nov 2004 13:29:14 -0000
@@ -936,8 +936,8 @@
s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
$(SET_LIB_PATH) \
$(HOST_EXPORTS) \
- (cd [+module+] && $(MAKE) $(FLAGS_TO_PASS) [+
- extra_make_flags+] check); \
+ (set +e; cd [+module+] && $(MAKE) -k $(FLAGS_TO_PASS) [+
+ extra_make_flags+] check; exit 0); \
fi
[+ ELSE check +]
check-[+module+]:
@@ -945,8 +945,8 @@
s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
$(SET_LIB_PATH) \
$(HOST_EXPORTS) \
- (cd [+module+] && $(MAKE) $(FLAGS_TO_PASS)[+
- extra_make_flags+] check)
+ (set +e; cd [+module+] && $(MAKE) -k $(FLAGS_TO_PASS)[+
+ extra_make_flags+] check; exit 0)
[+ ENDIF no_check +]
@endif [+module+]
@@ -1109,12 +1109,12 @@
ELSE normal_cxx +]
$(NORMAL_TARGET_EXPORTS) \[+
ENDIF raw_cxx +]
- (cd $(TARGET_SUBDIR)/[+module+] && \
- $(MAKE) $(TARGET_FLAGS_TO_PASS) [+
+ (set +e; cd $(TARGET_SUBDIR)/[+module+] && \
+ $(MAKE) -k $(TARGET_FLAGS_TO_PASS) [+
IF raw_cxx
+] 'CXX=$$(RAW_CXX_FOR_TARGET)' 'CXX_FOR_TARGET=$$(RAW_CXX_FOR_TARGET)' [+
ENDIF raw_cxx
- +] [+extra_make_flags+] check)
+ +] [+extra_make_flags+] check; exit 0)
[+ ENDIF no_check +]
@endif target-[+module+]
@@ -1265,7 +1265,8 @@
s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
$(SET_LIB_PATH) \
$(HOST_EXPORTS) \
- (cd gcc && $(MAKE) $(GCC_FLAGS_TO_PASS) check-c++); \
+ (set +e; cd gcc && $(MAKE) -k $(GCC_FLAGS_TO_PASS) check-c++; \
+ exit 0); \
else \
true; \
fi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-19 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-19 12:38 trunk broken for `make check' Karel Gardas
2004-11-19 12:56 ` Eric Botcazou
2004-11-19 16:20 ` [PATCH] " Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).