From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5160 invoked by alias); 20 Nov 2004 00:54:14 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 5002 invoked from network); 20 Nov 2004 00:54:05 -0000 Received: from unknown (HELO e2.ny.us.ibm.com) (32.97.182.102) by sourceware.org with SMTP; 20 Nov 2004 00:54:05 -0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.12.10/8.12.9) with ESMTP id iAK0s4G4337752 for ; Fri, 19 Nov 2004 19:54:04 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id iAK0s4ox287286 for ; Fri, 19 Nov 2004 19:54:04 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11/8.12.11) with ESMTP id iAK0s42I028515 for ; Fri, 19 Nov 2004 19:54:04 -0500 Received: from dyn318378bld.beaverton.ibm.com (DYN318378BLD.beaverton.ibm.com [9.47.18.189]) by d01av02.pok.ibm.com (8.12.11/8.12.11) with ESMTP id iAK0s36m028490; Fri, 19 Nov 2004 19:54:03 -0500 Received: from dyn318378bld.beaverton.ibm.com (localhost.localdomain [127.0.0.1]) by dyn318378bld.beaverton.ibm.com (8.12.8/8.12.8) with ESMTP id iAK0s0co007900; Fri, 19 Nov 2004 16:54:01 -0800 Received: (from janis@localhost) by dyn318378bld.beaverton.ibm.com (8.12.8/8.12.8/Submit) id iAK0rxAJ007898; Fri, 19 Nov 2004 16:53:59 -0800 X-Authentication-Warning: dyn318378bld.beaverton.ibm.com: janis set sender to janis187@us.ibm.com using -f Date: Sat, 20 Nov 2004 01:01:00 -0000 From: Janis Johnson To: Eric Botcazou Cc: Janis Johnson , gcc@gcc.gnu.org Subject: Re: Running the compat testsuite in "non-mirror" mode Message-ID: <20041120005359.GA7885@us.ibm.com> References: <200411180815.10873.ebotcazou@libertysurf.fr> <200411190914.31279.ebotcazou@libertysurf.fr> <20041119175829.GA4515@us.ibm.com> <200411191912.43024.ebotcazou@libertysurf.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411191912.43024.ebotcazou@libertysurf.fr> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-11/txt/msg00708.txt.bz2 On Fri, Nov 19, 2004 at 07:12:59PM +0100, Eric Botcazou wrote: > > I think I understand now. For anyone testing a particular target, the > > compat tests would be run first using the compiler under test to compile > > both parts of each test using default options, and again using different > > sets of options for the two parts of each test to make sure those > > options don't affect binary compatibility. Is that right? > > Yes; a maintainer of a given platform could decide that it is important to > always test a particular couple of options on this platform, and set the > appropriate bits in the right driver file. > > > This is probably easy to set up in the compat.exp file for each compat > > testsuite; I'll take a look. Does this do the kind of thing you want? This is just an example, not options I actually want to add for powerpc. Other files that set COMPAT_OPTIONS are lib/compat.exp, gcc.dg/compat/struct-layout-1.exp, and g++.dg/compat/compat.exp. This continues to allow the default sets of options to be overridden. Janis Index: gcc.dg/compat/compat.exp =================================================================== RCS file: /opt/gcc-cvs/gcc/gcc/testsuite/gcc.dg/compat/compat.exp,v retrieving revision 1.1 diff -u -p -r1.1 compat.exp --- gcc.dg/compat/compat.exp 5 May 2003 21:59:35 -0000 1.1 +++ gcc.dg/compat/compat.exp 20 Nov 2004 00:25:50 -0000 @@ -1,4 +1,4 @@ -# Copyright (C) 2002, 2003 Free Software Foundation, Inc. +# Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -34,6 +34,20 @@ global GCC_UNDER_TEST # Load procedures from common libraries. load_lib standard.exp load_lib gcc.exp +load_lib target-supports.exp + +# Some targets run the tests multiple times with different sets of options. +if ![info exists COMPAT_OPTIONS] { + if { [istarget powerpc*-*-linux*] && [is-effective-target vmx_hw] } { + set COMPAT_OPTIONS [list \ + [list {} {}] \ + [list {-maltivec -mabi=altivec} {-mno-altivec -mabi=altivec}]] + } elseif [istarget powerpc*-*-linux*] { + set COMPAT_OPTIONS [list \ + [list {} {}] \ + [list {-O1} {-O2}]] + } +} # # compat-use-alt-compiler -- make the alternate compiler the default @@ -65,7 +79,8 @@ proc compat-use-tst-compiler { } { } # Load the language-independent compabibility support procedures. -# This must be done after the compat-use-*-compiler definitions. +# This must be done after the compat-use-*-compiler definitions and +# after defining COMPAT_OPTIONS. load_lib compat.exp gcc_init