From: Richard Henderson <rth@redhat.com>
To: Richard Sandiford <rsandifo@redhat.com>,
Bob Wilson <bwilson@tensilica.com>,
gcc@gcc.gnu.org
Subject: Re: [cft] subreg validation round 2
Date: Mon, 22 Nov 2004 20:40:00 -0000 [thread overview]
Message-ID: <20041122185800.GA21727@redhat.com> (raw)
In-Reply-To: <20041119202228.GA18178@redhat.com>
On Fri, Nov 19, 2004 at 12:22:28PM -0800, Richard Henderson wrote:
> I think you have a point. I'll revert that part of the patch
> and fix this a different way. And update the documentation.
I never did find why I made this change. The only thing I can
think is that I was modifying something nearby and thought "this
obviously cannot be correct."
So I've applied this reversion.
r~
* function.c (assign_parm_setup_block): Revert 11-13 change to
forcably re-mode a (possibly BLKmode) hard register.
Index: function.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/function.c,v
retrieving revision 1.588
diff -c -p -d -u -r1.588 function.c
--- function.c 14 Nov 2004 06:22:56 -0000 1.588
+++ function.c 22 Nov 2004 18:52:41 -0000
@@ -2663,7 +2663,7 @@ assign_parm_setup_block (struct assign_p
{
rtx tem, x;
int by = (UNITS_PER_WORD - size) * BITS_PER_UNIT;
- rtx reg = gen_lowpart (word_mode, entry_parm);
+ rtx reg = gen_rtx_REG (word_mode, REGNO (entry_parm));
x = expand_shift (LSHIFT_EXPR, word_mode, reg,
build_int_cst (NULL_TREE, by),
next prev parent reply other threads:[~2004-11-22 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 18:58 Richard Henderson
2004-11-17 19:20 ` Bob Wilson
2004-11-17 19:58 ` Richard Henderson
2004-11-18 1:06 ` Alan Modra
2004-11-18 2:43 ` Bob Wilson
2004-11-18 16:23 ` Richard Sandiford
2004-11-19 21:39 ` Richard Henderson
2004-11-22 20:40 ` Richard Henderson [this message]
2004-11-17 22:32 ` Janis Johnson
2004-11-17 23:05 ` Andrew Pinski
2004-11-18 11:40 ` Alan Modra
2004-11-17 19:46 ` Eric Botcazou
2004-11-19 21:50 ` Richard Henderson
2004-11-19 22:43 ` Eric Botcazou
2004-11-19 22:46 ` Richard Henderson
2004-11-18 23:43 ` Kaz Kojima
2004-11-19 0:08 ` Janis Johnson
2004-11-17 19:19 Ulrich Weigand
[not found] <OF12E4E5CC.BDFB0F1C-ON41256F4F.0067F055-41256F4F.00682968@LocalDomain>
2004-11-17 21:42 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122185800.GA21727@redhat.com \
--to=rth@redhat.com \
--cc=bwilson@tensilica.com \
--cc=gcc@gcc.gnu.org \
--cc=rsandifo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).