From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21863 invoked by alias); 22 Nov 2004 18:58:13 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 21847 invoked from network); 22 Nov 2004 18:58:09 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 22 Nov 2004 18:58:09 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iAMIw425009957; Mon, 22 Nov 2004 13:58:04 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iAMIw3r16311; Mon, 22 Nov 2004 13:58:03 -0500 Received: from frothingslosh.sfbay.redhat.com (frothingslosh.sfbay.redhat.com [172.16.24.27]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id iAMIw1so027261; Mon, 22 Nov 2004 13:58:01 -0500 Received: from frothingslosh.sfbay.redhat.com (localhost.localdomain [127.0.0.1]) by frothingslosh.sfbay.redhat.com (8.13.1/8.13.1) with ESMTP id iAMIw07k021734; Mon, 22 Nov 2004 10:58:00 -0800 Received: (from rth@localhost) by frothingslosh.sfbay.redhat.com (8.13.1/8.13.1/Submit) id iAMIw0Kg021733; Mon, 22 Nov 2004 10:58:00 -0800 X-Authentication-Warning: frothingslosh.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Mon, 22 Nov 2004 20:40:00 -0000 From: Richard Henderson To: Richard Sandiford , Bob Wilson , gcc@gcc.gnu.org Subject: Re: [cft] subreg validation round 2 Message-ID: <20041122185800.GA21727@redhat.com> Mail-Followup-To: Richard Henderson , Richard Sandiford , Bob Wilson , gcc@gcc.gnu.org References: <20041117184009.GA12257@redhat.com> <419BA411.5090801@tensilica.com> <20041117194553.GA12418@redhat.com> <20041119202228.GA18178@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041119202228.GA18178@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-11/txt/msg00753.txt.bz2 On Fri, Nov 19, 2004 at 12:22:28PM -0800, Richard Henderson wrote: > I think you have a point. I'll revert that part of the patch > and fix this a different way. And update the documentation. I never did find why I made this change. The only thing I can think is that I was modifying something nearby and thought "this obviously cannot be correct." So I've applied this reversion. r~ * function.c (assign_parm_setup_block): Revert 11-13 change to forcably re-mode a (possibly BLKmode) hard register. Index: function.c =================================================================== RCS file: /cvs/gcc/gcc/gcc/function.c,v retrieving revision 1.588 diff -c -p -d -u -r1.588 function.c --- function.c 14 Nov 2004 06:22:56 -0000 1.588 +++ function.c 22 Nov 2004 18:52:41 -0000 @@ -2663,7 +2663,7 @@ assign_parm_setup_block (struct assign_p { rtx tem, x; int by = (UNITS_PER_WORD - size) * BITS_PER_UNIT; - rtx reg = gen_lowpart (word_mode, entry_parm); + rtx reg = gen_rtx_REG (word_mode, REGNO (entry_parm)); x = expand_shift (LSHIFT_EXPR, word_mode, reg, build_int_cst (NULL_TREE, by),