public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Bernd Schmidt <bernds_cb1@t-online.de>,
	gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [RFC] avoiding too narrow register classes in reload
Date: Wed, 15 Dec 2004 08:09:00 -0000	[thread overview]
Message-ID: <20041215080932.GB20219@redhat.com> (raw)
In-Reply-To: <orpt1crqwn.fsf@livre.redhat.lsd.ic.unicamp.br>

On Wed, Dec 15, 2004 at 04:56:08AM -0200, Alexandre Oliva wrote:
> 	* reload.c (SMALL_REGISTER_CLASS_P): New.
> 	(push_secondary_reload, find_reusable_reload, find_reloads): Use
> 	it instead of testing only the class size.

Ok, except,

> +#define SMALL_REGISTER_CLASS_P(C) \
> +  (reg_class_size [(int)(C)] == 1 \
> +   || (reg_class_size [(int)(C)] >= 1 && CLASS_LIKELY_SPILLED_P (C)))

We no longer have to cater to broken K&R compilers that refuse to
index arrays by enums.  Kill the casts.

> -		  if (reg_class_size[this_alternative[i]] == 1
> +		  if (reg_class_size[this_alternative[i]] > 0
> +		      && SMALL_REGISTER_CLASS_P (this_alternative[i])

reg_class_size check redundant with SMALL_REGISTER_CLASS_P.


r~

  reply	other threads:[~2004-12-15  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-13 21:20 Alexandre Oliva
2004-12-14  2:06 ` Richard Henderson
2004-12-14 21:20   ` Alexandre Oliva
2004-12-14 22:31     ` Richard Henderson
2004-12-15  6:56       ` Alexandre Oliva
2004-12-15  8:09         ` Richard Henderson [this message]
2004-12-15 20:07           ` Alexandre Oliva
2004-12-16 14:14             ` Dave Korn
2004-12-14 16:22 ` Bernd Schmidt
2004-12-14 20:53   ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041215080932.GB20219@redhat.com \
    --to=rth@redhat.com \
    --cc=aoliva@redhat.com \
    --cc=bernds_cb1@t-online.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).