From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-106600-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 6328 invoked by alias); 15 Dec 2004 08:09:55 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 6111 invoked from network); 15 Dec 2004 08:09:45 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 15 Dec 2004 08:09:45 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBF89eCn028672;
	Wed, 15 Dec 2004 03:09:45 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBF89Yr29347;
	Wed, 15 Dec 2004 03:09:34 -0500
Received: from frothingslosh.sfbay.redhat.com (frothingslosh.sfbay.redhat.com [172.16.24.27])
	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id iBF89W4a022876;
	Wed, 15 Dec 2004 03:09:33 -0500
Received: from frothingslosh.sfbay.redhat.com (localhost.localdomain [127.0.0.1])
	by frothingslosh.sfbay.redhat.com (8.13.1/8.13.1) with ESMTP id iBF89WN9020249;
	Wed, 15 Dec 2004 00:09:32 -0800
Received: (from rth@localhost)
	by frothingslosh.sfbay.redhat.com (8.13.1/8.13.1/Submit) id iBF89WQW020248;
	Wed, 15 Dec 2004 00:09:32 -0800
X-Authentication-Warning: frothingslosh.sfbay.redhat.com: rth set sender to rth@redhat.com using -f
Date: Wed, 15 Dec 2004 08:09:00 -0000
From: Richard Henderson <rth@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Bernd Schmidt <bernds_cb1@t-online.de>, gcc@gcc.gnu.org,
        gcc-patches@gcc.gnu.org
Subject: Re: [RFC] avoiding too narrow register classes in reload
Message-ID: <20041215080932.GB20219@redhat.com>
Mail-Followup-To: Richard Henderson <rth@redhat.com>,
	Alexandre Oliva <aoliva@redhat.com>,
	Bernd Schmidt <bernds_cb1@t-online.de>, gcc@gcc.gnu.org,
	gcc-patches@gcc.gnu.org
References: <oracshki96.fsf@livre.redhat.lsd.ic.unicamp.br> <20041214020635.GA16249@redhat.com> <ork6rktw51.fsf@livre.redhat.lsd.ic.unicamp.br> <20041214223127.GE19197@redhat.com> <orpt1crqwn.fsf@livre.redhat.lsd.ic.unicamp.br>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <orpt1crqwn.fsf@livre.redhat.lsd.ic.unicamp.br>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2004-12/txt/msg00562.txt.bz2

On Wed, Dec 15, 2004 at 04:56:08AM -0200, Alexandre Oliva wrote:
> 	* reload.c (SMALL_REGISTER_CLASS_P): New.
> 	(push_secondary_reload, find_reusable_reload, find_reloads): Use
> 	it instead of testing only the class size.

Ok, except,

> +#define SMALL_REGISTER_CLASS_P(C) \
> +  (reg_class_size [(int)(C)] == 1 \
> +   || (reg_class_size [(int)(C)] >= 1 && CLASS_LIKELY_SPILLED_P (C)))

We no longer have to cater to broken K&R compilers that refuse to
index arrays by enums.  Kill the casts.

> -		  if (reg_class_size[this_alternative[i]] == 1
> +		  if (reg_class_size[this_alternative[i]] > 0
> +		      && SMALL_REGISTER_CLASS_P (this_alternative[i])

reg_class_size check redundant with SMALL_REGISTER_CLASS_P.


r~