From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21379 invoked by alias); 17 Feb 2006 23:53:23 -0000 Received: (qmail 21371 invoked by uid 22791); 17 Feb 2006 23:53:22 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Feb 2006 23:53:21 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1HNqIMN026887; Fri, 17 Feb 2006 18:52:18 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1HNqC110891; Fri, 17 Feb 2006 18:52:12 -0500 Received: from louie.sfbay.redhat.com (louie.sfbay.redhat.com [192.168.28.4]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k1HNqA27025464; Fri, 17 Feb 2006 18:52:10 -0500 Received: from louie.sfbay.redhat.com (louie.sfbay.redhat.com [127.0.0.1]) by louie.sfbay.redhat.com (8.13.4/8.13.1) with ESMTP id k1HNqAB1018171; Fri, 17 Feb 2006 15:52:10 -0800 Received: (from rth@localhost) by louie.sfbay.redhat.com (8.13.4/8.13.4/Submit) id k1HNq9K3018170; Fri, 17 Feb 2006 15:52:09 -0800 Date: Fri, 17 Feb 2006 23:53:00 -0000 From: Richard Henderson To: Aldy Hernandez Cc: Mark Mitchell , gcc@gcc.gnu.org, dnovillo@redhat.com Subject: Re: pruning unused debugging types (enums/PR23336) Message-ID: <20060217235209.GA17049@redhat.com> Mail-Followup-To: Richard Henderson , Aldy Hernandez , Mark Mitchell , gcc@gcc.gnu.org, dnovillo@redhat.com References: <20051117220835.GA8907@redhat.com> <20051117230925.GB21279@redhat.com> <437D7395.8080000@codesourcery.com> <43F13C3B.7050008@codesourcery.com> <20060214115052.GA29895@redhat.com> <43F28D2A.60902@codesourcery.com> <20060216194057.GA30917@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060216194057.GA30917@redhat.com> User-Agent: Mutt/1.4.2.1i X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2006-02/txt/msg00354.txt.bz2 On Thu, Feb 16, 2006 at 03:40:57PM -0400, Aldy Hernandez wrote: > + htab_t GTY ((param_is (union tree_node))) used_types_hash; Should be "tree" not the union. You're storing a pointer, not the union itself. > +used_types_insert (tree t, struct function *cfun) Call it something other than cfun. Don't shadow globals this way. > + htab_traverse_noresize (cfun->used_types_hash, premark_used_types_helper, NULL); Shouldn't need to specify noresize. > @@ -6477,6 +6477,9 @@ store_parm_decls (void) > /* Initialize the RTL code for the function. */ > allocate_struct_function (fndecl); > > + cfun->used_types_hash = htab_create (37, htab_hash_pointer, > + htab_eq_pointer, NULL); This should be either done in function.c, or dwarf2out.c should be prepared for the hash to be null. r~