From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22814 invoked by alias); 2 Dec 2007 12:04:24 -0000 Received: (qmail 22804 invoked by uid 22791); 2 Dec 2007 12:04:23 -0000 X-Spam-Check-By: sourceware.org Received: from dair.pair.com (HELO dair.pair.com) (209.68.1.49) by sourceware.org (qpsmtpd/0.31) with SMTP; Sun, 02 Dec 2007 12:04:18 +0000 Received: (qmail 67886 invoked by uid 20157); 2 Dec 2007 12:04:17 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 2 Dec 2007 12:04:17 -0000 Date: Sun, 02 Dec 2007 12:04:00 -0000 From: Hans-Peter Nilsson To: Samuel Tardieu cc: gcc@gcc.gnu.org Subject: Re: Rant about ChangeLog entries and commit messages In-Reply-To: <2007-12-02-11-52-03+trackit+sam@rfc1149.net> Message-ID: <20071202065558.S8303@dair.pair.com> References: <2007-12-02-11-05-39+trackit+sam@rfc1149.net> <2007-12-02-11-52-03+trackit+sam@rfc1149.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00026.txt.bz2 On Sun, 2 Dec 2007, Samuel Tardieu wrote: > On 2/12, Andreas Schwab wrote: > > | That is supposed to be written in a comment. The change log entry > | should describe _what_ is being changed, so that you can find out when a > | particular change was made. > > This should be the job of the VCS, e.g. "svn log" and "svn blame". > Moreover, ChangeLogs are organized by directories. You have to look > at the "svn log" to see if a test corresponds to a code change and > identify it. The comment *in the code* is lacking, other than that I don't see much point in your rant; it's all been said before, for one. It usually takes a while for newcomers to understand the process, in particular the what-not-why of ChangeLogs... ;) brgds, H-P