From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9312 invoked by alias); 2 Dec 2007 11:32:25 -0000 Received: (qmail 9304 invoked by uid 22791); 2 Dec 2007 11:32:25 -0000 X-Spam-Check-By: sourceware.org Received: from mx-out.libertysurf.net (HELO mail.libertysurf.net) (213.36.80.91) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 11:32:19 +0000 Received: from [192.168.1.3] (83.156.55.88) by mail.libertysurf.net (7.3.118.8) id 46943A5F013196CF; Sun, 2 Dec 2007 12:32:16 +0100 From: Eric Botcazou To: Samuel Tardieu Subject: Re: Rant about ChangeLog entries and commit messages Date: Sun, 02 Dec 2007 11:32:00 -0000 User-Agent: KMail/1.7.1 Cc: gcc@gcc.gnu.org References: <2007-12-02-11-05-39+trackit+sam@rfc1149.net> <200712021151.08971.ebotcazou@libertysurf.fr> <2007-12-02-12-14-00+trackit+sam@rfc1149.net> In-Reply-To: <2007-12-02-12-14-00+trackit+sam@rfc1149.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712021232.25974.ebotcazou@libertysurf.fr> X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00023.txt.bz2 > I'll take an example from one of your recent changes in gcc/ChangeLog: > > 2007-11-19 Eric Botcazou > > * stor-layout.c (lang_adjust_rli): Delete. > (set_lang_adjust_rli): Likewise. > (layout_type): Do not call lang_adjust_rli hook. > * tree.h (set_lang_adjust_rli): Delete. > > Without digging in the mailing-list archives to see why you made the > change, if something new breaks on a STABS platform I will have no hint > that this change was in any way related to STABS. But this change has nothing to do with STABS. :-) > Also note that the ChangeLog doesn't give any hint that changes in the > ada directory have been made at the same time, only "svn log" reveals > that. So far for the "The purpose of this is so that people investigating > bugs in the future will know about the changes that might have introduced > the bug." sentence. Well, any changes in the compiler can potentially introduce bugs elsewhere and I suppose that you aren't proposing to mention all the known dependencies in the commit message. -- Eric Botcazou