From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29097 invoked by alias); 2 Dec 2007 23:54:11 -0000 Received: (qmail 29089 invoked by uid 22791); 2 Dec 2007 23:54:10 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 23:54:04 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 840189833F; Sun, 2 Dec 2007 23:54:01 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D29D598337; Sun, 2 Dec 2007 23:54:00 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IyydK-0002bO-DX; Sun, 02 Dec 2007 18:53:58 -0500 Date: Sun, 02 Dec 2007 23:54:00 -0000 From: Daniel Jacobowitz To: Ben Elliston Cc: Samuel Tardieu , gcc@gcc.gnu.org Subject: Re: Rant about ChangeLog entries and commit messages Message-ID: <20071202235358.GA9446@caradoc.them.org> Mail-Followup-To: Ben Elliston , Samuel Tardieu , gcc@gcc.gnu.org References: <2007-12-02-11-05-39+trackit+sam@rfc1149.net> <1196636533.16908.5.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1196636533.16908.5.camel@localhost> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00048.txt.bz2 On Mon, Dec 03, 2007 at 10:02:13AM +1100, Ben Elliston wrote: > Having said that, I find the lack of rationale for some changes to be a > bit irritating. I know that this should be done through code comments, > but those are often made across the changeset and in different files. > There is rarely a single summary of the need for the change. It would > be nice to consider a practice similar to that used by NetBSD, which is > to use a paragraph or so describing the need for the change (similar to > what we do when we introduce a patch on gcc-patches) and inserting that > comment into the svn commit message. Or even into the ChangeLog... I've worked on other projects that did this. I found it incredibly helpful. -- Daniel Jacobowitz CodeSourcery