libbid and floatingpoint exception access funcs

libbid and floatingpoint exception access funcs

[Bernhard Fischer]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Hi,

My libc is configured to omit any FP support (UCLIBC_HAS_FLOATS is not set)
but the recent libbid updates seems to unconditionally pull in floatingpoint
accessor functions thus breaking bootstrap. My notes on this read:

--------8<--------
Follows: 
Precedes: 

    do not pull in allegedly unneeded floatingpoint exception access funcs
    
      HJL's recent update of libbid would pull in Floating-point exception
      handling, although __GCC_FLOAT_NOT_NEEDED is defined.
    
      Prevent pulling in feclearexcept, feraiseexcept et al for now.
      FIXME: revisit
--------8<--------

H.J., please advise.

PS: I currently do:
libgcc/ChangeLog:
2007-10-13  Bernhard Fischer  <>

	* config/libbid/bid_conf.h: Do not define
	DECIMAL_GLOBAL_EXCEPTION_FLAGS_ACCESS_FUNCTIONS if
	__GCC_FLOAT_NOT_NEEDED is defined.

[-- Attachment #2: 306-libbid-no-decimal-global-exception-access-funcs.patch --]
[-- Type: text/x-diff, Size: 600 bytes --]

Index: gcc-4.3.0/libgcc/config/libbid/bid_conf.h
===================================================================
--- gcc-4.3.0/libgcc/config/libbid/bid_conf.h	(revision 129202)
+++ gcc-4.3.0/libgcc/config/libbid/bid_conf.h	(working copy)
@@ -535,7 +535,9 @@ Software Foundation, 51 Franklin Street,
 #define DECIMAL_GLOBAL_ROUNDING 1
 #define DECIMAL_GLOBAL_ROUNDING_ACCESS_FUNCTIONS 1
 #define DECIMAL_GLOBAL_EXCEPTION_FLAGS 1
+#ifndef __GCC_FLOAT_NOT_NEEDED
 #define DECIMAL_GLOBAL_EXCEPTION_FLAGS_ACCESS_FUNCTIONS 1
+#endif
 #define BID_HAS_GCC_DECIMAL_INTRINSICS 1
 #endif /* IN_LIBGCC2 */
 

Re: libbid and floatingpoint exception access funcs

[H.J. Lu]

Hi Bernhard,

Please open a gcc bug and assign it to me.

Thanks.


H.J.
---
On Wed, Dec 05, 2007 at 03:02:32PM +0100, Bernhard Fischer wrote:
> Hi,
> 
> My libc is configured to omit any FP support (UCLIBC_HAS_FLOATS is not set)
> but the recent libbid updates seems to unconditionally pull in floatingpoint
> accessor functions thus breaking bootstrap. My notes on this read:
> 
> --------8<--------
> Follows: 
> Precedes: 
> 
>     do not pull in allegedly unneeded floatingpoint exception access funcs
>     
>       HJL's recent update of libbid would pull in Floating-point exception
>       handling, although __GCC_FLOAT_NOT_NEEDED is defined.
>     
>       Prevent pulling in feclearexcept, feraiseexcept et al for now.
>       FIXME: revisit
> --------8<--------
> 
> H.J., please advise.
> 
> PS: I currently do:
> libgcc/ChangeLog:
> 2007-10-13  Bernhard Fischer  <>
> 
> 	* config/libbid/bid_conf.h: Do not define
> 	DECIMAL_GLOBAL_EXCEPTION_FLAGS_ACCESS_FUNCTIONS if
> 	__GCC_FLOAT_NOT_NEEDED is defined.

> Index: gcc-4.3.0/libgcc/config/libbid/bid_conf.h
> ===================================================================
> --- gcc-4.3.0/libgcc/config/libbid/bid_conf.h	(revision 129202)
> +++ gcc-4.3.0/libgcc/config/libbid/bid_conf.h	(working copy)
> @@ -535,7 +535,9 @@ Software Foundation, 51 Franklin Street,
>  #define DECIMAL_GLOBAL_ROUNDING 1
>  #define DECIMAL_GLOBAL_ROUNDING_ACCESS_FUNCTIONS 1
>  #define DECIMAL_GLOBAL_EXCEPTION_FLAGS 1
> +#ifndef __GCC_FLOAT_NOT_NEEDED
>  #define DECIMAL_GLOBAL_EXCEPTION_FLAGS_ACCESS_FUNCTIONS 1
> +#endif
>  #define BID_HAS_GCC_DECIMAL_INTRINSICS 1
>  #endif /* IN_LIBGCC2 */
>