From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25999 invoked by alias); 12 Jan 2008 00:48:19 -0000 Received: (qmail 25988 invoked by uid 22791); 12 Jan 2008 00:48:19 -0000 X-Spam-Check-By: sourceware.org Received: from us01smtp1.synopsys.com (HELO boden.synopsys.com) (198.182.44.79) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 Jan 2008 00:47:53 +0000 Received: from maiden.synopsys.com (maiden.synopsys.com [146.225.100.170]) by boden.synopsys.com (Postfix) with ESMTP id 78625DBF2; Fri, 11 Jan 2008 16:47:51 -0800 (PST) Received: from venkatar-opt-lnx.internal.synopsys.com (localhost [127.0.0.1]) by maiden.synopsys.com (8.9.1/8.9.1) with ESMTP id QAA04331; Fri, 11 Jan 2008 16:47:47 -0800 (PST) Received: from venkatar-opt-lnx.internal.synopsys.com (localhost.localdomain [127.0.0.1]) by venkatar-opt-lnx.internal.synopsys.com (8.13.1/8.12.3) with ESMTP id m0C0llpE022071; Fri, 11 Jan 2008 16:47:47 -0800 Received: (from jbuck@localhost) by venkatar-opt-lnx.internal.synopsys.com (8.13.1/8.13.1/Submit) id m0C0lfZX022070; Fri, 11 Jan 2008 16:47:41 -0800 Date: Sat, 12 Jan 2008 00:50:00 -0000 From: Joe Buck To: Ian Lance Taylor Cc: Rehno Lindeque , Ross Smith , gcc@gcc.gnu.org Subject: Re: -Wparentheses lumps too much together Message-ID: <20080112004741.GM19984@synopsys.com> References: <20071219200235.GA21525@oak.schemamania.org> <20071220005030.4971a442.jklowden@freetds.org> <200712201509.20582.paul@codesourcery.com> <476C1461.2050107@ihug.co.nz> <20080111165936.GB31668@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2008-01/txt/msg00162.txt.bz2 On Fri, Jan 11, 2008 at 03:24:46PM -0800, Ian Lance Taylor wrote: > Joe Buck writes: > > > A warning that flagged code like > > > > if (c1 || c2 && c3) > > ... > > > > would swamp users in warnings, since this kind of code is extremely > > common, and this isn't the kind of thing that anyone who's not a total C > > beginner has trouble with. > > That is what -Wparentheses does today. > > I think it's a good thing, because I've seen it catch coding errors in > real code. It appears that I was mistaken. Sorry for the noise.