From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28329 invoked by alias); 20 Jul 2009 14:27:34 -0000 Received: (qmail 28312 invoked by uid 22791); 20 Jul 2009 14:27:33 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jul 2009 14:27:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.14.3/8.13.8) with ESMTP id n6KER5u0576624 for ; Mon, 20 Jul 2009 14:27:05 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n6KEQxPv1863872 for ; Mon, 20 Jul 2009 16:27:05 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n6KEQxWL024442 for ; Mon, 20 Jul 2009 16:26:59 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n6KEQwOf024382; Mon, 20 Jul 2009 16:26:58 +0200 Message-Id: <200907201426.n6KEQwOf024382@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 20 Jul 2009 16:26:58 +0200 Subject: Re: i370 port To: mutazilah@gmail.com (Paul Edwards) Date: Mon, 20 Jul 2009 14:27:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz), gcc@gcc.gnu.org In-Reply-To: <9561B75B3A4540B3AEAAA6671D42E583@Paullaptop> from "Paul Edwards" at Jul 18, 2009 09:28:16 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-07/txt/msg00379.txt.bz2 Paul Edwards wrote: > I then found out that even with old versions of the machine definition, > I can have the warning removed by simply not defining CONST_INT > in the PREDICATE_CODES, even though it is allowed when the > function is called. ie it seems to have no effect on the code > generation, but succeeds in eliminating the warning, and without > needing to define an extra constraint for non-constant situations. Actually PREDICATE_CODES does have to match the predicate definitions. If it does not, you can run into subtle bugs, as the code in genrecog.c that generates the finite state automaton matching an RTX pattern against the .md insn definitions *does* make use of PREDICATE_CODES; for example, it will assume that two predicates with disjoint sets of PREDICATE_CODES can never both match the same RTX. This may or may not lead to visible differences when compiling simple test cases, but I'd expect effects to be visible in more complex scenarios. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com