public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Alexei I. Adamovich" <lexa@adam.botik.ru>
To: Ian Lance Taylor <iant@google.com>
Cc: gcc@gcc.gnu.org
Subject: Re: Help ! Frozen by a comment in gcc/c-common.h!
Date: Sun, 30 Aug 2009 03:04:00 -0000	[thread overview]
Message-ID: <20090829162921.GA23668@adam.botik.ru> (raw)
In-Reply-To: <m3hbvtyzcd.fsf@google.com>

Hi!

On Thu, Aug 27, 2009 at 09:51:30AM -0700, Ian Lance Taylor wrote:
> I suspect that that comment is no longer relevant.  At least, I can't
> seem to find the mask.  Perhaps somebody else knows.

I got. Since no anybody more has commented, let us be sure that the
mask mechanism has gone. [I've recently found corresponding bit mask in
gcc-3.3.6 in grokdeclarator (c-decl.c), e.g:
> 3589               if (i == RID_LONG && (specbits & (1 << (int) RID_LONG)))
or
> 3624               specbits |= 1 << (int) i;
where
> 3586           enum rid i = C_RID_CODE (id);
]

So for the sake of those who will develop C-derived front ends, should
we change the comment like below:
> /* Reserved identifiers.  This is the union of all the keywords for C,
>    C++, and Objective-C.  In the past, in earlier GCC versions all the
>    type modifiers had to be in one block at the beginning, because
>    they were used as mask bits.  There were 27 type modifiers; so if
>    anybody added many more the mask mechanism would have to be
>    redesigned.  Now it doesn't matter, since corresponding mask
>    machinery gone */
Should I (or you) submit a patch?

Alexei I. Adamovich

  reply	other threads:[~2009-08-29 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 13:29 Alexei I. Adamovich
2009-08-28  4:53 ` Ian Lance Taylor
2009-08-30  3:04   ` Alexei I. Adamovich [this message]
2009-08-30  6:58     ` Alexey I. Adamovich
2009-08-31 18:23       ` Ian Lance Taylor
2009-08-31 19:27         ` Alexey I. Adamovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090829162921.GA23668@adam.botik.ru \
    --to=lexa@adam.botik.ru \
    --cc=gcc@gcc.gnu.org \
    --cc=iant@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).