From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5228 invoked by alias); 29 Aug 2009 16:29:38 -0000 Received: (qmail 5217 invoked by uid 22791); 29 Aug 2009 16:29:37 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from pier.botik.ru (HELO pier.botik.ru) (193.232.174.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Aug 2009 16:29:27 +0000 Received: from adam.botik.ru ([193.232.174.4]:58882 ident=Debian-exim) by pier.botik.ru with esmtp (Exim 4.50) id 1MhQns-0002if-BA; Sat, 29 Aug 2009 20:29:24 +0400 Received: from lexa by adam.botik.ru with local (Exim 4.69) (envelope-from ) id 1MhQnp-00069u-RQ; Sat, 29 Aug 2009 20:29:21 +0400 Date: Sun, 30 Aug 2009 03:04:00 -0000 From: "Alexei I. Adamovich" To: Ian Lance Taylor Cc: gcc@gcc.gnu.org Bcc: "Alexei I. Adamovich" Subject: Re: Help ! Frozen by a comment in gcc/c-common.h! Message-ID: <20090829162921.GA23668@adam.botik.ru> References: <20090827115025.GA7870@adam.botik.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-08/txt/msg00543.txt.bz2 Hi! On Thu, Aug 27, 2009 at 09:51:30AM -0700, Ian Lance Taylor wrote: > I suspect that that comment is no longer relevant. At least, I can't > seem to find the mask. Perhaps somebody else knows. I got. Since no anybody more has commented, let us be sure that the mask mechanism has gone. [I've recently found corresponding bit mask in gcc-3.3.6 in grokdeclarator (c-decl.c), e.g: > 3589 if (i == RID_LONG && (specbits & (1 << (int) RID_LONG))) or > 3624 specbits |= 1 << (int) i; where > 3586 enum rid i = C_RID_CODE (id); ] So for the sake of those who will develop C-derived front ends, should we change the comment like below: > /* Reserved identifiers. This is the union of all the keywords for C, > C++, and Objective-C. In the past, in earlier GCC versions all the > type modifiers had to be in one block at the beginning, because > they were used as mask bits. There were 27 type modifiers; so if > anybody added many more the mask mechanism would have to be > redesigned. Now it doesn't matter, since corresponding mask > machinery gone */ Should I (or you) submit a patch? Alexei I. Adamovich