From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17208 invoked by alias); 29 Aug 2009 19:42:54 -0000 Received: (qmail 17197 invoked by uid 22791); 29 Aug 2009 19:42:53 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from pier.botik.ru (HELO pier.botik.ru) (193.232.174.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 29 Aug 2009 19:42:47 +0000 Received: from dm.botik.ru ([193.232.174.32]:59743 ident=postfix) by pier.botik.ru with esmtp (Exim 4.50) id 1MhToy-0006tK-VT; Sat, 29 Aug 2009 23:42:45 +0400 Received: by dm.botik.ru (Postfix, from userid 1001) id C64631300A6B; Sat, 29 Aug 2009 23:42:44 +0400 (MSD) Date: Sun, 30 Aug 2009 06:58:00 -0000 To: gcc@gcc.gnu.org Cc: Ian Lance Taylor Subject: Re: Help ! Frozen by a comment in gcc/c-common.h! Message-ID: <20090829194244.GA20643@dm.botik.ru> References: <20090827115025.GA7870@adam.botik.ru> <20090829162921.GA23668@adam.botik.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090829162921.GA23668@adam.botik.ru> User-Agent: Mutt/1.5.20 (2009-06-14) From: lexa@dm.botik.ru (Alexey I. Adamovich) Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-08/txt/msg00544.txt.bz2 Forgot RID_LAST_MODIFIER On Sat, Aug 29, 2009 at 08:29:21PM +0400, Alexei I. Adamovich wrote: > So for the sake of those who will develop C-derived front ends, should > we change the comment like below: > > /* Reserved identifiers. This is the union of all the keywords for C, > > C++, and Objective-C. In the past, in earlier GCC versions all the > > type modifiers had to be in one block at the beginning, because > > they were used as mask bits. There were 27 type modifiers; so if > > anybody added many more the mask mechanism would have to be > > redesigned. Now it doesn't matter, since corresponding mask > > machinery gone */ Should the last lines be re-written as follows: > redesigned. Now it doesn't matter, since corresponding mask > machinery gone. But anyway when adding any type modifier it's > better to follow the old rule and to get sure that > RID_LAST_MODIFIER is defined and handled correctly also */ [?] Alexei I. Adamovich