From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18101 invoked by alias); 25 Sep 2009 00:28:21 -0000 Received: (qmail 18090 invoked by uid 22791); 25 Sep 2009 00:28:21 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from vinc17.pck.nerim.net (HELO prunille.vinc17.org) (213.41.242.187) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Sep 2009 00:28:16 +0000 Received: by prunille.vinc17.org (Postfix, from userid 501) id AF5A94000053; Fri, 25 Sep 2009 02:28:13 +0200 (CEST) Date: Fri, 25 Sep 2009 02:33:00 -0000 From: Vincent Lefevre To: Kaveh Ghazi Cc: gcc@gcc.gnu.org Subject: Outdated comment in real.c (was: constant folding) Message-ID: <20090925002813.GB582@prunille.vinc17.org> Mail-Followup-To: Kaveh Ghazi , gcc@gcc.gnu.org References: <20090925001855.GU657@prunille.vinc17.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090925001855.GU657@prunille.vinc17.org> X-Mailer-Info: http://www.vinc17.org/mutt/ User-Agent: Mutt/1.5.20-6022-vl-r30587 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00528.txt.bz2 [Cc to the gcc mailing-list] On 2009-09-25 02:18:55 +0200, Vincent Lefevre wrote: > Also, as EXP_BITS is the full (biased) exponent size, it seems that > the real.c comment is buggy (27 -> 26). Looking at the history: Index: real.h =================================================================== --- real.h (revision 107860) +++ real.h (revision 107861) @@ -35,7 +35,7 @@ }; #define SIGNIFICAND_BITS (128 + HOST_BITS_PER_LONG) -#define EXP_BITS (32 - 5) +#define EXP_BITS (32 - 6) #define MAX_EXP ((1 << (EXP_BITS - 1)) - 1) [...] but real.c wasn't updated: it still has denormal number fits in 17 exponent bits; we store 27. that comes from r83133. -- Vincent Lefèvre - Web: 100% accessible validated (X)HTML - Blog: Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)