From: Martin Jambor <mjambor@suse.cz>
To: Richard Guenther <rguenther@suse.de>
Cc: Diego Novillo <dnovillo@google.com>,
Sebastian Pop <sebpop@gmail.com>,
gcc@gcc.gnu.org
Subject: Re: Copy assignments for non scalar types
Date: Wed, 14 Apr 2010 11:45:00 -0000 [thread overview]
Message-ID: <20100414114434.GA9108@virgil.suse.cz> (raw)
In-Reply-To: <alpine.LNX.2.00.1004141330250.5522@zhemvz.fhfr.qr>
Hi,
On Wed, Apr 14, 2010 at 01:31:05PM +0200, Richard Guenther wrote:
> On Wed, 14 Apr 2010, Diego Novillo wrote:
>
> > On Wed, Apr 14, 2010 at 04:40, Richard Guenther <rguenther@suse.de> wrote:
> >
> > > No. make_rename_temp should go away. Please.
> >
> > I don't disagree, in principle (less code is always good). What is
> > wrong with it?
>
> It asks the SSA renamer to put your new variables into SSA form.
> It's very simple to do that manually (at least if no PHIs are
> involved), so better do that.
>
The problem of using create_tmp_var directly is that the following
pattern is now bound to creep up at quite many places:
tmp = create_tmp_var (TREE_TYPE (adj->base), "blah");
if (TREE_CODE (TREE_TYPE (tmp)) == COMPLEX_TYPE
|| TREE_CODE (TREE_TYPE (tmp)) == VECTOR_TYPE)
DECL_GIMPLE_REG_P (tmp) = 1;
Perhaps we should have something like create_gimple_reg_tmp_var that
would do this? If so, I'll be happy to add it.
Martin
next prev parent reply other threads:[~2010-04-14 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 19:16 Sebastian Pop
2010-04-13 19:43 ` Jakub Jelinek
2010-04-13 20:19 ` Sebastian Pop
2010-04-13 20:52 ` Eric Botcazou
2010-04-13 19:47 ` Sebastian Pop
2010-04-14 9:29 ` Richard Guenther
2010-04-14 11:12 ` Diego Novillo
2010-04-14 11:44 ` Richard Guenther
2010-04-14 11:45 ` Martin Jambor [this message]
2010-04-14 12:12 ` Richard Guenther
2010-04-14 12:01 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414114434.GA9108@virgil.suse.cz \
--to=mjambor@suse.cz \
--cc=dnovillo@google.com \
--cc=gcc@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).