From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10614 invoked by alias); 14 Apr 2010 11:44:43 -0000 Received: (qmail 10604 invoked by uid 22791); 14 Apr 2010 11:44:42 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Apr 2010 11:44:36 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 96D6086A2E; Wed, 14 Apr 2010 13:44:34 +0200 (CEST) Date: Wed, 14 Apr 2010 11:45:00 -0000 From: Martin Jambor To: Richard Guenther Cc: Diego Novillo , Sebastian Pop , gcc@gcc.gnu.org Subject: Re: Copy assignments for non scalar types Message-ID: <20100414114434.GA9108@virgil.suse.cz> Mail-Followup-To: Richard Guenther , Diego Novillo , Sebastian Pop , gcc@gcc.gnu.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-04/txt/msg00324.txt.bz2 Hi, On Wed, Apr 14, 2010 at 01:31:05PM +0200, Richard Guenther wrote: > On Wed, 14 Apr 2010, Diego Novillo wrote: > > > On Wed, Apr 14, 2010 at 04:40, Richard Guenther wrote: > > > > > No. make_rename_temp should go away. Please. > > > > I don't disagree, in principle (less code is always good). What is > > wrong with it? > > It asks the SSA renamer to put your new variables into SSA form. > It's very simple to do that manually (at least if no PHIs are > involved), so better do that. > The problem of using create_tmp_var directly is that the following pattern is now bound to creep up at quite many places: tmp = create_tmp_var (TREE_TYPE (adj->base), "blah"); if (TREE_CODE (TREE_TYPE (tmp)) == COMPLEX_TYPE || TREE_CODE (TREE_TYPE (tmp)) == VECTOR_TYPE) DECL_GIMPLE_REG_P (tmp) = 1; Perhaps we should have something like create_gimple_reg_tmp_var that would do this? If so, I'll be happy to add it. Martin