From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27938 invoked by alias); 21 Apr 2010 12:10:53 -0000 Received: (qmail 27918 invoked by uid 22791); 21 Apr 2010 12:10:51 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sunsite.ms.mff.cuni.cz (HELO sunsite.mff.cuni.cz) (195.113.15.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 12:10:47 +0000 Received: from sunsite.mff.cuni.cz (localhost [127.0.0.1]) by sunsite.mff.cuni.cz (8.14.3/8.14.3) with ESMTP id o3LCAi5T014568; Wed, 21 Apr 2010 14:10:44 +0200 Received: (from jakub@localhost) by sunsite.mff.cuni.cz (8.14.3/8.14.3/Submit) id o3LCAiVe014566; Wed, 21 Apr 2010 14:10:44 +0200 Date: Wed, 21 Apr 2010 12:32:00 -0000 From: Jakub Jelinek To: GCC Mailing List , Jakub Jelinek , Jan Hubicka Subject: Re: Are non-DECL_COMDAT nodes in same_comdat_group lists OK? Message-ID: <20100421121044.GD5553@sunsite.ms.mff.cuni.cz> Reply-To: Jakub Jelinek References: <20100421115321.GA27665@virgil.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100421115321.GA27665@virgil.suse.cz> User-Agent: Mutt/1.5.19 (2009-01-05) Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-04/txt/msg00437.txt.bz2 On Wed, Apr 21, 2010 at 01:53:21PM +0200, Martin Jambor wrote: > when putting together a patch to fix PR 43812 I wanted to extend > the call graph verifier to verify that > > 1) the same_comdat_group linked lists are indeed circular, > 2) there are no one element lists, and > 3) all nodes in such lists have the flag DECL_COMDAT (node->decl) set. All notes should have same non-NULL DECL_COMDAT_GROUP, that's something different from DECL_COMDAT (non-NULL DECL_COMDAT_GROUP is DECL_ONE_ONLY property). Jakub