From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18581 invoked by alias); 27 Aug 2010 14:23:15 -0000 Received: (qmail 18572 invoked by uid 22791); 27 Aug 2010 14:23:14 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Aug 2010 14:23:08 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D6829CB0300; Fri, 27 Aug 2010 16:23:04 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xM+IBY8BwMM1; Fri, 27 Aug 2010 16:23:04 +0200 (CEST) Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) by mel.act-europe.fr (Postfix) with ESMTP id BE7D6CB01E8; Fri, 27 Aug 2010 16:23:04 +0200 (CEST) Received: by province.act-europe.fr (Postfix, from userid 525) id 9F60A164894; Fri, 27 Aug 2010 16:23:04 +0200 (CEST) Date: Fri, 27 Aug 2010 14:43:00 -0000 From: Arnaud Charlet To: jeremie.salvucci@free.fr Cc: gcc , laurynas , basile Subject: Re: Gengtype : strange code in output_type_enum Message-ID: <20100827142304.GA15681@adacore.com> References: <1117289297.446531282913343686.JavaMail.root@zimbra30-e5.priv.proxad.net> <662566448.453381282918810720.JavaMail.root@zimbra30-e5.priv.proxad.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <662566448.453381282918810720.JavaMail.root@zimbra30-e5.priv.proxad.net> User-Agent: Mutt/1.5.17 (2007-11-01) Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-08/txt/msg00396.txt.bz2 > In function output_type_enum of gcc/gengtype.c, we replaced > > - if (s->kind == TYPE_PARAM_STRUCT && s->u.s.line.file != NULL) > + if (s->kind == TYPE_PARAM_STRUCT && s->u.param_struct.line.file != > NULL) > > And Gengtype works like before with c,c++, lto enabled. > > Do you think we have to submit a one line patch (if yes, could it be reviewed Sure, one line patches are actually welcome since they are well isolated and easy to review, as opposed to large big patches containing unrelated stuff which have basically zero chance to get accepted/reviewed (other than "please break you patch into multiple pieces). Arno