From: Jakub Jelinek <jakub@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Richard Henderson <rth@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Gerald Pfeifer <gerald@pfeifer.com>,
Steve Kargl <sgk@troutmask.apl.washington.edu>,
Fortran List <fortran@gcc.gnu.org>,
FX <fxcoudert@gmail.com>,
gcc@gcc.gnu.org
Subject: Re: For testing: full __float128 patch
Date: Mon, 30 Aug 2010 19:54:00 -0000 [thread overview]
Message-ID: <20100830193839.GM4815@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <AANLkTi=s=nsN60paQLh7ihLOYETDKCU36Yj5KYChM+pC@mail.gmail.com>
On Mon, Aug 30, 2010 at 09:25:42PM +0200, Uros Bizjak wrote:
> On Mon, Aug 30, 2010 at 7:53 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
> >>> I'm not familiar in versioning stuff, but since soft-fp symbols are
> >>> part of generic libgcc-std.ver for a long time (before 4.5.0), I
> >>> believe, it is enough to patch only configure files (see i.e. commits
> >>> that enabled soft-fp on mingw/cygwin/-gnu*).
> >>
> >> It will "work", but not properly. Â One should never have symbols
> >> magically appear in old versions. Â If you add the symbols to the
> >> proper current version number in a config/gcc/i386/libgcc-bsd.ver,
> >> they'll appear at the right place.
> >
> > Can someone please help here?
>
> Attached is my best (untested) shot at libgcc-bsd.ver. Someone has to
> write i386/t-freebsd (similar to i386/t-linux) and connect it to the
> build system. The versioning assumes that this will be committed to
> 4.5.x first.
It is wrong, GCC 4.5.0 has been released already, so no new symbols should
be added to GCC_4.5.0 symver.
IMNSHO this isn't a regression fix, so you should just apply it to the
trunk, and introduce them as GCC_4.6.0 version. Also, there is no need
to have two chunks for the same symver in the *.ver file, just put the
3 resp. 2 symbols before the preceeding closing brace, together with the
%ifdef/%else/%endif.
Jakub
next prev parent reply other threads:[~2010-08-30 19:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 1:55 Uros Bizjak
2010-08-30 1:59 ` Steve Kargl
2010-08-30 7:42 ` Uros Bizjak
2010-08-30 10:46 ` Gerald Pfeifer
2010-08-30 16:48 ` Gerald Pfeifer
2010-08-30 17:34 ` Joseph S. Myers
2010-08-30 17:43 ` Uros Bizjak
2010-08-30 18:27 ` Richard Henderson
2010-08-30 19:25 ` Uros Bizjak
2010-08-30 19:38 ` Uros Bizjak
2010-08-30 19:51 ` Richard Henderson
2010-08-30 19:54 ` Jakub Jelinek [this message]
2010-08-30 22:29 ` Uros Bizjak
2010-08-31 4:32 ` Steve Kargl
2010-08-31 7:10 ` Steve Kargl
2010-08-31 3:37 ` Joseph S. Myers
2010-08-30 17:37 ` Steve Kargl
-- strict thread matches above, loose matches on Subject: below --
2010-08-29 0:57 FX
2010-08-29 1:48 ` Steve Kargl
2010-08-29 7:03 ` Steve Kargl
2010-08-29 11:43 ` Steve Kargl
2010-08-29 12:02 ` FX
2010-08-29 20:48 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830193839.GM4815@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=fxcoudert@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=joseph@codesourcery.com \
--cc=rth@redhat.com \
--cc=sgk@troutmask.apl.washington.edu \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).