public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Basile Starynkevitch <basile@starynkevitch.net>
To: gcc@gcc.gnu.org
Subject: autogen version testing in fixincludes/genfixes
Date: Wed, 08 Jun 2011 06:29:00 -0000	[thread overview]
Message-ID: <20110608082914.76c339f2.basile@starynkevitch.net> (raw)


Hello

With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or
perhaps /Experimental) the genfixes script fail, because of the version
test.

The following patch corrects that.

Index: fixincludes/genfixes
===================================================================
--- fixincludes/genfixes	(revision 174734)
+++ fixincludes/genfixes	(working copy)
@@ -62,7 +62,7 @@
 AG="autogen $AG"
 set -e
 
-if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
+if [ -z "`${AG} -v | fgrep ' 5.'`" ]
 then
   echo "AutoGen appears to be out of date or not correctly installed."
   echo "Please download and install:"

Should I submit the patch, or is there something I missed? 

Why do we test the Ver. string ???

Regards.
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

             reply	other threads:[~2011-06-08  6:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  6:29 Basile Starynkevitch [this message]
2011-06-08  8:07 ` Andreas Schwab
2011-06-08 18:29   ` Basile Starynkevitch
2011-06-08 18:53     ` Andreas Schwab
2011-06-08 19:40       ` Basile Starynkevitch
2011-06-08 19:55         ` Andreas Schwab
2011-06-08 20:01           ` Basile Starynkevitch
2011-08-06 15:33           ` Marc Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608082914.76c339f2.basile@starynkevitch.net \
    --to=basile@starynkevitch.net \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).