From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22523 invoked by alias); 8 Jun 2011 06:29:36 -0000 Received: (qmail 22515 invoked by uid 22791); 8 Jun 2011 06:29:35 -0000 X-SWARE-Spam-Status: No, hits=-0.0 required=5.0 tests=AWL,BAYES_05,RDNS_DYNAMIC,TVD_RCVD_IP X-Spam-Check-By: sourceware.org Received: from 195-14-0-142.nuxit.net (HELO de558.ispfr.net) (195.14.0.142) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Jun 2011 06:29:18 +0000 Received: from ours.starynkevitch.net ([213.41.244.95] helo=glinka.lesours) by de558.ispfr.net with smtp (Exim 4.72) (envelope-from ) id 1QUCGS-0005e5-8n for gcc@gcc.gnu.org; Wed, 08 Jun 2011 08:29:16 +0200 Date: Wed, 08 Jun 2011 06:29:00 -0000 From: Basile Starynkevitch To: gcc@gcc.gnu.org Subject: autogen version testing in fixincludes/genfixes Message-Id: <20110608082914.76c339f2.basile@starynkevitch.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00081.txt.bz2 Hello With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or perhaps /Experimental) the genfixes script fail, because of the version test. The following patch corrects that. Index: fixincludes/genfixes =================================================================== --- fixincludes/genfixes (revision 174734) +++ fixincludes/genfixes (working copy) @@ -62,7 +62,7 @@ AG="autogen $AG" set -e -if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ] +if [ -z "`${AG} -v | fgrep ' 5.'`" ] then echo "AutoGen appears to be out of date or not correctly installed." echo "Please download and install:" Should I submit the patch, or is there something I missed? Why do we test the Ver. string ??? Regards. -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***