Re: autogen version testing in fixincludes/genfixes

[Basile Starynkevitch <basile@starynkevitch.net>]

On Wed, 08 Jun 2011 10:07:20 +0200
Andreas Schwab <schwab@redhat.com> wrote:

> Basile Starynkevitch <basile@starynkevitch.net> writes:
> 
> > Hello
> >
> > With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or
> > perhaps /Experimental) the genfixes script fail, because of the version
> > test.
> >
> > The following patch corrects that.
> >
> > Index: fixincludes/genfixes
> > ===================================================================
> > --- fixincludes/genfixes	(revision 174734)
> > +++ fixincludes/genfixes	(working copy)
> > @@ -62,7 +62,7 @@
> >  AG="autogen $AG"
> >  set -e
> >  
> > -if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ]
> > +if [ -z "`${AG} -v | fgrep ' 5.'`" ]
> 
> What happens when autogen 6 is released?

I don't know, but I would imagine that autogen -v gave a different
string between 5.11.9 and some previous version, which probably was
also a 5.xx (not too far, since it worked on Debian/Sid a month ago)

What I find strange is to fgrep for the 'Ver.' string. The digit 5 is
ok for me. Here is what I get today:

% autogen --version
autogen (GNU AutoGen) 5.11.9
% autogen -v
autogen (GNU AutoGen) 5.11.9

You see, not Ver. string in it.

And current autogen behavior is not surprising; several other GNU
utilities have the same format : % ls --version
ls (GNU coreutils) 8.5
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>. This is free software: you are free
to change and redistribute it. There is NO WARRANTY, to the extent
permitted by law.

Written by Richard M. Stallman and David MacKenzie.

% gcc --version
gcc (Debian 4.6.0-10) 4.6.1 20110526 (prerelease)
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is
NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

% find --version
find (GNU findutils) 4.5.10
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>. This is free software: you are free
to change and redistribute it. There is NO WARRANTY, to the extent
permitted by law.

Written by Eric B. Decker, James Youngman, and Kevin Dalley.
Built using GNU gnulib version 25d7f3a59bfdc7aaca4a016f687826883a55bef3
Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS
(FTS_CWDFD) CBO(level=2) 

% autoconf --version
autoconf (GNU Autoconf) 2.64
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later
<http://gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
 % ld --version
GNU ld (GNU Binutils for Debian) 2.21.51.20110601
Copyright 2011 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms
of the GNU General Public License version 3 or (at your option) a later
version. This program has absolutely no warranty.


So most of the GNU tools I have have a quite similar format for telling
their version. The first line of the output of --version don't have a
Ver. string it it.

Of course, I have LANG=C in all cases.

Regards
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***