From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6341 invoked by alias); 8 Jun 2011 18:29:43 -0000 Received: (qmail 6331 invoked by uid 22791); 8 Jun 2011 18:29:43 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC,TVD_RCVD_IP X-Spam-Check-By: sourceware.org Received: from 195-14-0-142.nuxit.net (HELO de558.ispfr.net) (195.14.0.142) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Jun 2011 18:29:26 +0000 Received: from ours.starynkevitch.net ([213.41.244.95] helo=glinka.lesours) by de558.ispfr.net with smtp (Exim 4.72) (envelope-from ) id 1QUNVL-00043l-Ix; Wed, 08 Jun 2011 20:29:23 +0200 Date: Wed, 08 Jun 2011 18:29:00 -0000 From: Basile Starynkevitch To: Andreas Schwab Cc: gcc@gcc.gnu.org Subject: Re: autogen version testing in fixincludes/genfixes Message-Id: <20110608202921.b98c1302.basile@starynkevitch.net> In-Reply-To: References: <20110608082914.76c339f2.basile@starynkevitch.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00086.txt.bz2 On Wed, 08 Jun 2011 10:07:20 +0200 Andreas Schwab wrote: > Basile Starynkevitch writes: > > > Hello > > > > With the autogen (GNU AutoGen) 5.11.9 on my Linux/Debian/Sid (or > > perhaps /Experimental) the genfixes script fail, because of the version > > test. > > > > The following patch corrects that. > > > > Index: fixincludes/genfixes > > =================================================================== > > --- fixincludes/genfixes (revision 174734) > > +++ fixincludes/genfixes (working copy) > > @@ -62,7 +62,7 @@ > > AG="autogen $AG" > > set -e > > > > -if [ -z "`${AG} -v | fgrep 'Ver. 5.'`" ] > > +if [ -z "`${AG} -v | fgrep ' 5.'`" ] > > What happens when autogen 6 is released? I don't know, but I would imagine that autogen -v gave a different string between 5.11.9 and some previous version, which probably was also a 5.xx (not too far, since it worked on Debian/Sid a month ago) What I find strange is to fgrep for the 'Ver.' string. The digit 5 is ok for me. Here is what I get today: % autogen --version autogen (GNU AutoGen) 5.11.9 % autogen -v autogen (GNU AutoGen) 5.11.9 You see, not Ver. string in it. And current autogen behavior is not surprising; several other GNU utilities have the same format : % ls --version ls (GNU coreutils) 8.5 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard M. Stallman and David MacKenzie. % gcc --version gcc (Debian 4.6.0-10) 4.6.1 20110526 (prerelease) Copyright (C) 2011 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. % find --version find (GNU findutils) 4.5.10 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Eric B. Decker, James Youngman, and Kevin Dalley. Built using GNU gnulib version 25d7f3a59bfdc7aaca4a016f687826883a55bef3 Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATION FTS (FTS_CWDFD) CBO(level=2) % autoconf --version autoconf (GNU Autoconf) 2.64 Copyright (C) 2009 Free Software Foundation, Inc. License GPLv2+: GNU GPL version 2 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David J. MacKenzie and Akim Demaille. % ld --version GNU ld (GNU Binutils for Debian) 2.21.51.20110601 Copyright 2011 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or (at your option) a later version. This program has absolutely no warranty. So most of the GNU tools I have have a quite similar format for telling their version. The first line of the output of --version don't have a Ver. string it it. Of course, I have LANG=C in all cases. Regards -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} ***