From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4055 invoked by alias); 13 Oct 2011 20:20:28 -0000 Received: (qmail 3857 invoked by uid 22791); 13 Oct 2011 20:20:25 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_VB X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 20:20:10 +0000 Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id p9DKK8Sh020842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Oct 2011 13:20:09 -0700 Date: Fri, 14 Oct 2011 01:50:00 -0000 Message-Id: <20111013.162008.36415523038357600.davem@davemloft.net> To: rth@redhat.com Cc: gcc@gcc.gnu.org Subject: Re: VIS2 pattern review From: David Miller In-Reply-To: <4E9744BB.1060903@redhat.com> References: <4E96358F.30405@redhat.com> <20111013.155559.1663153362558602407.davem@davemloft.net> <4E9744BB.1060903@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg00215.txt.bz2 From: Richard Henderson Date: Thu, 13 Oct 2011 13:06:19 -0700 > On 10/13/2011 12:55 PM, David Miller wrote: >> -(define_insn "_vis" >> +(define_insn "" > > Missing a "3" on the end. Otherwise these look ok. Thanks for finding that. >> Unfortunately, that would involve some ABI changes for the VIS >> builtins. I'm trending towards considering just changing things >> anyways since the VIS intrinsics were next to unusable beforehand. > > Why? You can do just about anything you like inside the builtin > expander, including frobbing the modes around. Hmmm, ok, I'll look into approaching the change that way. Thanks again Richard.