public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Benjamin Kosnik <bkoz@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: GCC <gcc@gcc.gnu.org>
Subject: Re: Potentially merging cxx-mem-model with mainline.
Date: Thu, 27 Oct 2011 05:22:00 -0000	[thread overview]
Message-ID: <20111026093100.42f49182@shotwell> (raw)
In-Reply-To: <4EA8296F.2020300@redhat.com>


> Whats left
> ===========
> Functionality is pretty much complete, but there are a few minor lose 
> ends still to deal with. They could be done after a merge, in the
> next stage, or required before... you tell me :-)
> 
> - potentially implement -f[no]-inline-atomics  (to never produce
> inline code and always call the library) and
> -f[no]-atomic-compare-swap-loop (To not fall back to a
> compare_and_swap loop to implement missing functionality)
> 
> - unaligned objects have undefined behaviour at the moment.
> Behaviour could be defined and add alignment checks and a parameter
> to __atomic_is_lock_free() for alignment checking purposes.  Anything
> which doesn't map to one of the properly aligned  5 sized built-ins
> gets a library call.


> - A bit of C++ template restructuring in the include files to remove
> the old fall back locked implementation and fully use the new
> __atomic builtins. (*in progress now*)

Hit me off-line about this. Hopefully I can help expedite.
 
> - Change external library calls for __atomic_op_fetch routines.
> (*patch submitted already*)
> 
> - There are a bunch of new tests that have been developed along the
> way, but I I expect to spend the next 2 months writing more detailed
> and specific runtime and compile time tests. And of course, fixing
> any of the fall out from those tests.

Yes. I don't see this as a blocker for the merge.
 

> The final word
> =============
> So what is the opinion/consensus on merging the branch?  It would be 
> nice to get this infrastructure in place for this release so we can
> get people to start using it, and then we can work out any issues
> that arise.
> 
> I'd have Aldy do the actual merge because if I do something will go
> amok for sure.  I wont be around this weekend to fix any fallout, but
> I am around until Friday evening.  I'm around all next week.  I don't 
> anticipate much problem since this is all new functionality for the
> most part, and mainline was merged with the branch a week or two ago.

I am really expecting this branch to be merged for 4.7. The current
status is very presentable IMHO.

-benjamin

  parent reply	other threads:[~2011-10-26 17:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 17:38 Andrew MacLeod
2011-10-26 18:59 ` David Gilbert
2011-10-27  5:22 ` Benjamin Kosnik [this message]
2011-10-27 11:58   ` Richard Guenther
2011-10-27 17:51     ` Andrew MacLeod
2011-10-27  6:29 ` Joseph S. Myers
2011-10-31 15:58 ` Aldy Hernandez
     [not found]   ` <mcrbosxvvww.fsf@dhcp-172-18-216-180.mtv.corp.google.com>
2012-06-10 22:03     ` Renaming Stage 1 and Stage 3 Gerald Pfeifer
2012-06-11  9:18       ` Richard Guenther
2012-06-11 10:28         ` Dodji Seketeli
2012-06-11 12:21           ` Andrew MacLeod
2012-06-11 13:57             ` Diego Novillo
2012-06-11 12:17         ` Paolo Bonzini
2012-06-11 14:16         ` Miles Bader
2012-06-11 14:18           ` Richard Guenther
2012-06-11 15:05         ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111026093100.42f49182@shotwell \
    --to=bkoz@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).