public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
@ 2013-08-19 17:43 Jan-Benedict Glaw
  2013-08-20 10:57 ` Alexander Ivchenko
  0 siblings, 1 reply; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-08-19 17:43 UTC (permalink / raw)
  To: Alexander Ivchenko; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]

Hi!

My build robot[1] catched this error[2] while cross-building for
powerpc64le-linux:

g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace   \
../../../../gcc/gcc/config/linux-android.c
../../../../gcc/gcc/config/linux-android.c: In function ‘bool linux_android_libc_has_function(function_class)’:
../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
   if (OPTION_BIONIC)
       ^
make[2]: *** [linux-android.o] Error 1

Probably introduced with r201838
(http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201838). I
guess it's just a forgotten chunk.

MfG, JBG
[1] http://toolchain.lug-owl.de/buildbot/
[2] http://toolchain.lug-owl.de/buildbot/#job8903

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
 Signature of:                      http://perl.plover.com/Questions.html
 the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-08-19 17:43 [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope Jan-Benedict Glaw
@ 2013-08-20 10:57 ` Alexander Ivchenko
  2013-08-21 14:54   ` [buildrobot] .../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ " Jan-Benedict Glaw
  2013-08-26 16:19   ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
  0 siblings, 2 replies; 11+ messages in thread
From: Alexander Ivchenko @ 2013-08-20 10:57 UTC (permalink / raw)
  To: Jan-Benedict Glaw, gcc

Hi, thanks for cathing this.

I certainly missed that OPTION_BIONIC is not defined for linux targets
that do not include config/linux.h in their tm.h.

This patch fixed build for powerpc64le-linux and mn10300-linux.
linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 56e6fd4..6bb18f8 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2013-08-20  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+       * config/linux-android.c (linux_android_libc_has_function): Fix
+       checks for libc.
+
 2013-08-20  Zhouyi Zhou <yizhouzhou@ict.ac.cn>

        * tree-ssa-ccp.c (get_default_value): Remove redundant condition
diff --git a/gcc/config/linux-android.c b/gcc/config/linux-android.c
index 4a4b48d..e9d9e9a 100644
--- a/gcc/config/linux-android.c
+++ b/gcc/config/linux-android.c
@@ -35,9 +35,9 @@ linux_android_has_ifunc_p (void)
 bool
 linux_android_libc_has_function (enum function_class fn_class)
 {
-  if (OPTION_GLIBC)
+  if (linux_libc == LIBC_GLIBC)
     return true;
-  if (OPTION_BIONIC)
+  if (linux_libc == LIBC_BIONIC)
     if (fn_class == function_c94
        || fn_class == function_c99_misc
        || fn_class == function_sincos)



is it OK?


thanks,
Alexander

2013/8/19 Jan-Benedict Glaw <jbglaw@lug-owl.de>:
> Hi!
>
> My build robot[1] catched this error[2] while cross-building for
> powerpc64le-linux:
>
> g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace   \
> ../../../../gcc/gcc/config/linux-android.c
> ../../../../gcc/gcc/config/linux-android.c: In function ‘bool linux_android_libc_has_function(function_class)’:
> ../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
>    if (OPTION_BIONIC)
>        ^
> make[2]: *** [linux-android.o] Error 1
>
> Probably introduced with r201838
> (http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201838). I
> guess it's just a forgotten chunk.
>
> MfG, JBG
> [1] http://toolchain.lug-owl.de/buildbot/
> [2] http://toolchain.lug-owl.de/buildbot/#job8903
>
> --
>       Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
>  Signature of:                      http://perl.plover.com/Questions.html
>  the second  :

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [buildrobot] .../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ was not declared in this scope
  2013-08-20 10:57 ` Alexander Ivchenko
@ 2013-08-21 14:54   ` Jan-Benedict Glaw
  2013-08-26 16:19   ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
  1 sibling, 0 replies; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-08-21 14:54 UTC (permalink / raw)
  To: Alexander Ivchenko; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 2055 bytes --]

On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Hi, thanks for cathing this.
> 
> I certainly missed that OPTION_BIONIC is not defined for linux targets
> that do not include config/linux.h in their tm.h.

Slightly different, but tic6x-uclinux
(http://toolchain.lug-owl.de/buildbot/?id=9018 , with build log being
available at
http://toolchain.lug-owl.de/buildbot/showlog.php?id=9018&mode=view)
probably also affected:

 g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    \
../../../../gcc/gcc/config/c6x/c6x.c -o c6x.o
In file included from ./tm.h:24:0,
                 from ../../../../gcc/gcc/config/c6x/c6x.c:25:
../../../../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ was not declared in this scope
 #define TARGET_LIBC_HAS_FUNCTION linux_android_libc_has_function
                                  ^
./target-hooks-def.h:1100:5: note: in expansion of macro ‘TARGET_LIBC_HAS_FUNCTION’
     TARGET_LIBC_HAS_FUNCTION, \
     ^
../../../../gcc/gcc/config/c6x/c6x.c:6839:29: note: in expansion of macro ‘TARGET_INITIALIZER’
 struct gcc_target targetm = TARGET_INITIALIZER;
                             ^


MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second  :               Langsam möchte ich mal wieder weiterträumen können.
                             -- Maximilian Wilhelm (18. Mai 2005, #lug-owl.de)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-08-20 10:57 ` Alexander Ivchenko
  2013-08-21 14:54   ` [buildrobot] .../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ " Jan-Benedict Glaw
@ 2013-08-26 16:19   ` Jan-Benedict Glaw
  2013-09-02 21:28     ` [ping^2] " Jan-Benedict Glaw
  2013-09-06 13:31     ` [ping] " Jan-Benedict Glaw
  1 sibling, 2 replies; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-08-26 16:19 UTC (permalink / raw)
  To: Alexander Ivchenko; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

Hi!

On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Hi, thanks for cathing this.
> 
> I certainly missed that OPTION_BIONIC is not defined for linux targets
> that do not include config/linux.h in their tm.h.
> 
> This patch fixed build for powerpc64le-linux and mn10300-linux.
> linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
[...]

It would be nice if somebody would review this patch. The initial
commit had fallout on a few targets:

alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537&mode=view
mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655&mode=view
tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647&mode=view
powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638&mode=view
(all other PPC variants, too.)

Thanks, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:               http://www.eyrie.org/~eagle/faqs/questions.html
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-08-26 16:19   ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
@ 2013-09-02 21:28     ` Jan-Benedict Glaw
  2013-09-02 22:10       ` David Edelsohn
  2013-09-06 13:31     ` [ping] " Jan-Benedict Glaw
  1 sibling, 1 reply; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-09-02 21:28 UTC (permalink / raw)
  To: Alexander Ivchenko; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

Hi!

On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> > I certainly missed that OPTION_BIONIC is not defined for linux targets
> > that do not include config/linux.h in their tm.h.
> > 
> > This patch fixed build for powerpc64le-linux and mn10300-linux.
> > linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
> [...]
> 
> It would be nice if somebody would review this patch. The initial
> commit had fallout on a few targets:
> 
> alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537&mode=view
> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
> sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655&mode=view
> tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647&mode=view
> powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638&mode=view
> (all other PPC variants, too.)

This is still broken. Today it's two weeks.  Can we please have the
patch ACKed or revert the patch?

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
 Signature of:                            If it doesn't work, force it.
 the second  :                   If it breaks, it needed replacing anyway.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-09-02 21:28     ` [ping^2] " Jan-Benedict Glaw
@ 2013-09-02 22:10       ` David Edelsohn
  2013-09-03  7:48         ` Richard Biener
  0 siblings, 1 reply; 11+ messages in thread
From: David Edelsohn @ 2013-09-02 22:10 UTC (permalink / raw)
  To: Jan-Benedict Glaw, Jakub Jelinek, Richard Biener; +Cc: Alexander Ivchenko, gcc

On Mon, Sep 2, 2013 at 5:28 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> Hi!
>
> On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>> > I certainly missed that OPTION_BIONIC is not defined for linux targets
>> > that do not include config/linux.h in their tm.h.
>> >
>> > This patch fixed build for powerpc64le-linux and mn10300-linux.
>> > linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
>> [...]
>>
>> It would be nice if somebody would review this patch. The initial
>> commit had fallout on a few targets:
>>
>> alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537&mode=view
>> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
>> sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655&mode=view
>> tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647&mode=view
>> powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638&mode=view
>> (all other PPC variants, too.)
>
> This is still broken. Today it's two weeks.  Can we please have the
> patch ACKed or revert the patch?

I agree. This is ridiculous. Would some global reviewer please approve the fix?

Thanks, David

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ping^2] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-09-02 22:10       ` David Edelsohn
@ 2013-09-03  7:48         ` Richard Biener
  0 siblings, 0 replies; 11+ messages in thread
From: Richard Biener @ 2013-09-03  7:48 UTC (permalink / raw)
  To: David Edelsohn; +Cc: Jan-Benedict Glaw, Jakub Jelinek, Alexander Ivchenko, gcc

On Mon, 2 Sep 2013, David Edelsohn wrote:

> On Mon, Sep 2, 2013 at 5:28 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > Hi!
> >
> > On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> >> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> >> > I certainly missed that OPTION_BIONIC is not defined for linux targets
> >> > that do not include config/linux.h in their tm.h.
> >> >
> >> > This patch fixed build for powerpc64le-linux and mn10300-linux.
> >> > linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
> >> [...]
> >>
> >> It would be nice if somebody would review this patch. The initial
> >> commit had fallout on a few targets:
> >>
> >> alpha-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9537&mode=view
> >> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
> >> sparc64-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9655&mode=view
> >> tic6x-uclinux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9647&mode=view
> >> powerpc64le-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9638&mode=view
> >> (all other PPC variants, too.)
> >
> > This is still broken. Today it's two weeks.  Can we please have the
> > patch ACKed or revert the patch?
> 
> I agree. This is ridiculous. Would some global reviewer please approve the fix?

Patch is ok.

_Please_ mark patches properly and send them in a separate thread.
Otherwise I just notice [buildbot] and skip the mail.  A proper
subject would be [PATCH] Unbreak bootstrap on XYZ

Richard.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-08-26 16:19   ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
  2013-09-02 21:28     ` [ping^2] " Jan-Benedict Glaw
@ 2013-09-06 13:31     ` Jan-Benedict Glaw
  2013-09-10  0:01       ` Maxim Kuvyrkov
  1 sibling, 1 reply; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-09-06 13:31 UTC (permalink / raw)
  To: Alexander Ivchenko; +Cc: gcc

[-- Attachment #1: Type: text/plain, Size: 2307 bytes --]

On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> > Hi, thanks for cathing this.
> > 
> > I certainly missed that OPTION_BIONIC is not defined for linux targets
> > that do not include config/linux.h in their tm.h.
> > 
> > This patch fixed build for powerpc64le-linux and mn10300-linux.
> > linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
> [...]

Seems the commit at Thu Sep 5 13:01:35 2013 (CEST) fixed most of the
fallout.  Thanks!

> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view

This however still seems to have issues in a current build:

	http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520&mode=view

 g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    -I. -I. -I../../../../gcc/gcc -I../../../../gcc/gcc/. -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace   \
../../../../gcc/gcc/config/linux-android.c
../../../../gcc/gcc/config/linux-android.c: In function ‘bool linux_android_libc_has_function(function_class)’:
../../../../gcc/gcc/config/linux-android.c:38:7: error: ‘OPTION_GLIBC’ was not declared in this scope
   if (OPTION_GLIBC)
       ^
../../../../gcc/gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
   if (OPTION_BIONIC)
       ^
make[2]: *** [linux-android.o] Error 1

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:              Träume nicht von Deinem Leben: Lebe Deinen Traum!
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-09-06 13:31     ` [ping] " Jan-Benedict Glaw
@ 2013-09-10  0:01       ` Maxim Kuvyrkov
  2013-09-10 10:07         ` Jan-Benedict Glaw
  2013-09-10 22:10         ` Joseph S. Myers
  0 siblings, 2 replies; 11+ messages in thread
From: Maxim Kuvyrkov @ 2013-09-10  0:01 UTC (permalink / raw)
  To: Jan-Benedict Glaw, Jeff Law; +Cc: Alexander Ivchenko, gcc

On 7/09/2013, at 1:31 AM, Jan-Benedict Glaw wrote:

> On Mon, 2013-08-26 12:51:53 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> On Tue, 2013-08-20 11:24:31 +0400, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>>> Hi, thanks for cathing this.
>>> 
>>> I certainly missed that OPTION_BIONIC is not defined for linux targets
>>> that do not include config/linux.h in their tm.h.
>>> 
>>> This patch fixed build for powerpc64le-linux and mn10300-linux.
>>> linux_libc, LIBC_GLIBC, LIBC_BIONIC should be defined for all targets.
>> [...]
> 
> Seems the commit at Thu Sep 5 13:01:35 2013 (CEST) fixed most of the
> fallout.  Thanks!
> 
>> mn10300-linux: http://toolchain.lug-owl.de/buildbot/showlog.php?id=9657&mode=view
> 
> This however still seems to have issues in a current build:
> 
> 	http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520&mode=view

Jan-Benedict,

Mn10300-linux does not appear to be supporting linux.  Mn10300-linux target specifier expands into mn10300-unknown-linux-gnu, where *-gnu implies using Glibc library, which doesn't have mn10300 port.

Jeff,

You are mn10300 maintainer, is building GCC for mn10300-unknown-linux-gnu supposed to work?  

Thanks,

--
Maxim Kuvyrkov
www.kugelworks.com

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-09-10  0:01       ` Maxim Kuvyrkov
@ 2013-09-10 10:07         ` Jan-Benedict Glaw
  2013-09-10 22:10         ` Joseph S. Myers
  1 sibling, 0 replies; 11+ messages in thread
From: Jan-Benedict Glaw @ 2013-09-10 10:07 UTC (permalink / raw)
  To: Maxim Kuvyrkov; +Cc: Jeff Law, Alexander Ivchenko, gcc

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

On Tue, 2013-09-10 12:01:34 +1200, Maxim Kuvyrkov <maxim@kugelworks.com> wrote:
> On 7/09/2013, at 1:31 AM, Jan-Benedict Glaw wrote:
> > This however still seems to have issues in a current build:
> > 
> > 	http://toolchain.lug-owl.de/buildbot/showlog.php?id=10520&mode=view
> 
> Mn10300-linux does not appear to be supporting linux.  Mn10300-linux
> target specifier expands into mn10300-unknown-linux-gnu, where *-gnu
> implies using Glibc library, which doesn't have mn10300 port.

Uh, I would have expected an error message then (from configury), but
you may well be right. I changed over to mn10300-elf for now.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:            http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: Re: [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope
  2013-09-10  0:01       ` Maxim Kuvyrkov
  2013-09-10 10:07         ` Jan-Benedict Glaw
@ 2013-09-10 22:10         ` Joseph S. Myers
  1 sibling, 0 replies; 11+ messages in thread
From: Joseph S. Myers @ 2013-09-10 22:10 UTC (permalink / raw)
  To: Maxim Kuvyrkov; +Cc: Jan-Benedict Glaw, Jeff Law, Alexander Ivchenko, gcc

On Tue, 10 Sep 2013, Maxim Kuvyrkov wrote:

> Mn10300-linux does not appear to be supporting linux.  Mn10300-linux 
> target specifier expands into mn10300-unknown-linux-gnu, where *-gnu 
> implies using Glibc library, which doesn't have mn10300 port.

It's called am33, and the GCC port is also called am33_2.0-*-linux*.  
(But given the lack of any updates to the glibc patches sent by the 
prospective port maintainer over a year ago 
<https://sourceware.org/ml/libc-ports/2012-06/msg00066.html>, following my 
review comments, I'm inclined to think it's time to remove the very 
bitrotten glibc port.)

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2013-09-10 22:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-19 17:43 [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ was not declared in this scope Jan-Benedict Glaw
2013-08-20 10:57 ` Alexander Ivchenko
2013-08-21 14:54   ` [buildrobot] .../gcc/gcc/config/linux.h:105:34: error: ‘linux_android_libc_has_function’ " Jan-Benedict Glaw
2013-08-26 16:19   ` [ping] [buildrobot] gcc/config/linux-android.c:40:7: error: ‘OPTION_BIONIC’ " Jan-Benedict Glaw
2013-09-02 21:28     ` [ping^2] " Jan-Benedict Glaw
2013-09-02 22:10       ` David Edelsohn
2013-09-03  7:48         ` Richard Biener
2013-09-06 13:31     ` [ping] " Jan-Benedict Glaw
2013-09-10  0:01       ` Maxim Kuvyrkov
2013-09-10 10:07         ` Jan-Benedict Glaw
2013-09-10 22:10         ` Joseph S. Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).