From: Ilya Verbin <iverbin@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>
Cc: Uday Khedker <uday@cse.iitb.ac.in>,
hubicka@ucw.cz, rth@redhat.com, kirill.yukhin@gmail.com,
"Michael V. Zolotukhin" <michael.v.zolotukhin@gmail.com>,
gcc@gcc.gnu.org
Subject: Re: Questions about LTO infrastructure and pragma omp target
Date: Sun, 25 Aug 2013 22:36:00 -0000 [thread overview]
Message-ID: <20130823171514.GB6976@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <20130823123638.GL1814@tucnak.redhat.com>
On 23 Aug 13:17, Jakub Jelinek wrote:
> I don't think we should stream into more than one target section.
> There should be just .gnu.target_lto section (or whatever other suitable
> name) and should stream into it:
> 1) all functions and variables with "omp declare target" attribute
> 2) the outlined bodies of #pragma omp target turned into *.ompfn functions
> 3) all the types, symtab etc. needed for that
Why having one target section is preferable than multiple sections for each
function body?
> Then the question is what the plugin should perform with these sections,
> whether it will compile each input .gnu.target_lto section hunk separately
> (as in non-LTO mode), or with -flto also LTO them together.
Yes, it is an important question... To get started it is easier to implement
"non-target-lto" mode, however this approach should be general enough to extend
it to "target-lto" mode. Does anyone need it?
On 23 Aug 14:36, Jakub Jelinek wrote:
> On Fri, Aug 23, 2013 at 02:24:42PM +0200, Richard Biener wrote:
> > No, as you will refer to the symbol with the target code from the host
> > code you need a single unified symtab.
>
> I really think you want two symtabs rather than a unified symtab,
> or just stream a subset of the host symtab into the .gnu.target_lto
> section. The thing is, the target code (functions, vars, outlined bodies)
> is a strict subset of the host code (because as a fallback, everything
> needs to be able to run on the host), but when not compiling originally with
> -flto, we IMHO should stream just the target subset, not everything
> (and for -flto stream both the target subset into one section and everything
> (host code) as we do right now, either with fat or slim lto objects).
I also think that having two symtabs looks better. There is no direct refs to
the target symbols from the host code. And (as far as I see it) unified symtab
will lead to mess in places, where host and target symbols should be handled
differently.
Thanks,
-- Ilya
next prev parent reply other threads:[~2013-08-23 17:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 13:44 Ilya Verbin
2013-08-15 15:00 ` Jakub Jelinek
2013-08-15 19:19 ` Richard Biener
2013-08-23 13:15 ` Ilya Verbin
2013-08-23 14:38 ` Jakub Jelinek
2013-08-28 9:59 ` Basile Starynkevitch
2013-08-23 15:05 ` Richard Biener
2013-08-23 15:06 ` Jakub Jelinek
2013-08-25 22:36 ` Ilya Verbin [this message]
2013-08-26 7:32 ` Jakub Jelinek
2013-09-03 14:00 ` Michael V. Zolotukhin
2013-09-03 14:19 ` Jakub Jelinek
2013-09-03 15:18 ` Michael V. Zolotukhin
2013-09-03 17:39 ` Thomas Schwinge
2013-09-03 18:30 ` Michael V. Zolotukhin
2013-09-03 18:54 ` Jakub Jelinek
2013-09-03 19:09 ` Michael V. Zolotukhin
2013-09-16 17:14 ` Ilya Verbin
2013-09-17 8:12 ` Richard Biener
2013-09-17 11:31 ` Ilya Verbin
2013-09-17 11:54 ` Jakub Jelinek
2013-09-17 11:56 ` Richard Biener
2013-09-17 12:15 ` Jakub Jelinek
2013-09-19 10:45 ` Ilya Verbin
2013-09-19 10:50 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823171514.GB6976@msticlxl57.ims.intel.com \
--to=iverbin@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=michael.v.zolotukhin@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=rth@redhat.com \
--cc=uday@cse.iitb.ac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).