From: "Michael V. Zolotukhin" <michael.v.zolotukhin@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
Richard Henderson <rth@redhat.com>,
gcc@gcc.gnu.org, triegel@redhat.com
Subject: Re: [RFC] Offloading Support in libgomp
Date: Fri, 13 Sep 2013 13:11:00 -0000 [thread overview]
Message-ID: <20130913131109.GD30181@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <20130913123614.GB1817@tucnak.redhat.com>
> But I doubt dirent.h is portable to all targets we support, so I believe it
> needs another configure test, and perhaps we want to define some macro
> whether we actually support offloading at all (HAVE_DLFCN_H would be one
> precondition, HAVE_DIRENT_H (with opendir etc.) another one (for this the
> question is if we are building libgomp with LFS flags also, i.e. opendir64
> etc. if available) another requirement we have is that sizeof (void *) ==
> sizeof (uintptr_t), etc.
That sounds reasonable, I'll do it.
> I'm afraid strnlen isn't sufficiently portable. Why don't you just use
> strlen?
strnlen was used as it's more secure than strlen (on non-constant strings).
However, maybe that's not so critical in this place. And anyway, we could use
strnlen when it's available and strlen otherwise.
> resolve_device should be changed to return struct gomp_device_descr *
> (or NULL for host fallback), and this pthread_once done inside of
> resolve_device, not in all the callers.
> Aliasing violation, don't do that.
Will fix, thanks.
> FYI, I'm attaching a WIP patch with the splay tree stuff.
Thanks, I'll take a look. By the way, isn't it better to move splay-tree
implementation to a separate file?
Michael
> Jakub
next prev parent reply other threads:[~2013-09-13 13:11 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 22:37 Michael V. Zolotukhin
2013-08-23 0:22 ` Jakub Jelinek
2013-08-23 12:16 ` Michael V. Zolotukhin
2013-08-23 12:37 ` Jakub Jelinek
2013-08-24 6:17 ` Michael V. Zolotukhin
2013-08-25 16:24 ` Jakub Jelinek
2013-08-27 0:36 ` Michael V. Zolotukhin
2013-08-27 0:38 ` Jakub Jelinek
2013-08-27 6:16 ` Michael V. Zolotukhin
2013-08-27 8:06 ` Jakub Jelinek
2013-08-27 15:47 ` Michael V. Zolotukhin
2013-08-27 16:22 ` Jakub Jelinek
2013-08-27 19:54 ` Michael V. Zolotukhin
2013-08-28 11:21 ` Jakub Jelinek
2013-08-29 10:44 ` Michael V. Zolotukhin
2013-09-10 15:02 ` Michael V. Zolotukhin
2013-09-10 15:15 ` Jakub Jelinek
2013-09-10 15:31 ` Michael V. Zolotukhin
2013-09-10 15:36 ` Jakub Jelinek
2013-09-10 15:38 ` Michael V. Zolotukhin
2013-09-13 11:30 ` Michael V. Zolotukhin
2013-09-13 12:36 ` Jakub Jelinek
2013-09-13 13:11 ` Michael V. Zolotukhin [this message]
2013-09-13 13:16 ` Jakub Jelinek
2013-09-13 15:09 ` Ilya Tocar
2013-09-13 15:34 ` Jakub Jelinek
2014-07-17 7:52 ` Thomas Schwinge
2014-07-17 12:30 ` Ilya Verbin
2014-07-17 12:37 ` Jakub Jelinek
2014-07-17 12:58 ` Thomas Schwinge
2014-07-17 13:09 ` Thomas Schwinge
2014-07-17 13:35 ` Jakub Jelinek
2014-07-17 14:37 ` Thomas Schwinge
2013-09-13 9:35 ` Michael Zolotukhin
2013-09-13 10:52 ` Kirill Yukhin
2013-09-13 11:04 ` Nathan Sidwell
2013-09-13 11:21 ` Michael V. Zolotukhin
2013-09-16 9:35 ` Jakub Jelinek
2013-09-17 12:05 ` Michael V. Zolotukhin
2013-09-17 12:30 ` Jakub Jelinek
2013-10-28 10:43 ` Ilya Verbin
2013-10-29 8:04 ` Jakub Jelinek
2014-01-31 18:03 ` Ilya Verbin
2014-01-31 19:43 ` Jakub Jelinek
2014-02-14 15:24 ` Ilya Verbin
2014-02-14 15:43 ` Jakub Jelinek
2014-02-14 18:54 ` Richard Henderson
2014-02-17 15:59 ` Ilya Verbin
2014-02-17 16:03 ` Jakub Jelinek
2013-08-28 12:56 ` Richard Biener
2013-08-28 15:26 ` Jakub Jelinek
2013-08-28 17:03 ` Richard Biener
2013-08-28 17:15 ` Jakub Jelinek
2013-08-29 21:09 ` Richard Biener
2013-08-28 18:54 ` Torvald Riegel
2013-08-28 18:43 ` Torvald Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913131109.GD30181@msticlxl57.ims.intel.com \
--to=michael.v.zolotukhin@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=rth@redhat.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).