From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7379 invoked by alias); 17 Feb 2014 16:03:25 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 7365 invoked by uid 89); 17 Feb 2014 16:03:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2014 16:03:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1HG3Lwp007244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 17 Feb 2014 11:03:21 -0500 Received: from tucnak.zalov.cz (ovpn-116-35.ams2.redhat.com [10.36.116.35]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1HG3Jmr022815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Feb 2014 11:03:20 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.7/8.14.7) with ESMTP id s1HG3GeY009174; Mon, 17 Feb 2014 17:03:17 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.7/8.14.7/Submit) id s1HG3Dhp009173; Mon, 17 Feb 2014 17:03:13 +0100 Date: Mon, 17 Feb 2014 16:03:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: Richard Henderson , "Michael V. Zolotukhin" , Kirill Yukhin , GCC Development , triegel@redhat.com, Sergey Ostanevich Subject: Re: [RFC] Offloading Support in libgomp Message-ID: <20140217160313.GF22862@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20130916093549.GP1817@tucnak.redhat.com> <20130917120454.GE60139@msticlxl57.ims.intel.com> <20130917122927.GY1817@tucnak.redhat.com> <20131028104110.GA11997@msticlxl57.ims.intel.com> <20131029070331.GT30970@tucnak.zalov.cz> <20140131180334.GY892@tucnak.redhat.com> <20140214154304.GG20378@tucnak.redhat.com> <20140217155916.GA12035@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140217155916.GA12035@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00257.txt.bz2 On Mon, Feb 17, 2014 at 07:59:16PM +0400, Ilya Verbin wrote: > On 14 Feb 16:43, Jakub Jelinek wrote: > > So, perhaps we should just stop for now oring the copyfrom in and just use > > the copyfrom from the very first mapping only, and wait for what the committee > > actually agrees on. > > > > Jakub > > Like this? > > @@ -171,11 +171,16 @@ gomp_map_vars_existing (splay_tree_key oldn, splay_tree_key newn, > "[%p..%p) is already mapped", > (void *) newn->host_start, (void *) newn->host_end, > (void *) oldn->host_start, (void *) oldn->host_end); > +#if 0 > + /* FIXME: Remove this when OpenMP 4.0 will be standardized. Currently it's > + unclear regarding overwriting copy_from for the existing mapping. > + See http://gcc.gnu.org/ml/gcc/2014-02/msg00208.html for details. */ > if (((kind & 7) == 2 || (kind & 7) == 3) > && !oldn->copy_from > && oldn->host_start == newn->host_start > && oldn->host_end == newn->host_end) > oldn->copy_from = true; > +#endif > oldn->refcount++; > } Well, OpenMP 4.0 is a released standard, just in some cases ambiguous or buggy. I'd just remove the code rather than putting it into #if 0, patch preapproved. It will stay in the SVN history... Jakub