public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Bill Schmidt <wschmidt@linux.vnet.ibm.com>
Cc: Maxim Ostapenko <m.ostapenko@samsung.com>, gcc@gcc.gnu.org
Subject: Re: -fsanitize=thread support on ppc64
Date: Mon, 23 Jan 2017 14:32:00 -0000	[thread overview]
Message-ID: <20170123143246.GN1867@tucnak> (raw)
In-Reply-To: <96208690-44F0-4648-8C24-4A8DC7966B5F@linux.vnet.ibm.com>

On Mon, Jan 23, 2017 at 08:22:30AM -0600, Bill Schmidt wrote:
> TSan support was contributed to LLVM by a student working at one of the US 
> National Labs a while back.  I helped him with some of the PPC assembly
> programming.  To my knowledge this is working, but I haven't tested this with
> GCC.  Do you think we want to change the configuration for GCC this late in the
> release?  I can run a quick test with TSan turned on to see where we're at.

I think it should be enabled if it works, even this late.
I bet we need something like the following patch on top of
the PR79168 patch.

I'll test both patches on both ppc64le and ppc64.

Another question is, it seems upstream has s390{,x}-*-linux* support for
asan/ubsan, does that work?  In that case we should add it to configure.tgt
too (similarly to the sparc*-*-linux* entry).

2017-01-23  Jakub Jelinek  <jakub@redhat.com>

	* configure.tgt: Enable tsan and lsan on powerpc64{,le}-*-linux*.

--- libsanitizer/configure.tgt.jj	2016-11-09 15:22:50.000000000 +0100
+++ libsanitizer/configure.tgt	2017-01-23 15:25:21.059399613 +0100
@@ -1,5 +1,5 @@
 # -*- shell-script -*-
-#   Copyright (C) 2012 Free Software Foundation, Inc.
+#   Copyright (C) 2012-2017 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -31,6 +31,11 @@ case "${target}" in
 	fi
 	;;
   powerpc*-*-linux*)
+	if test x$ac_cv_sizeof_void_p = x8; then
+		TSAN_SUPPORTED=yes
+		LSAN_SUPPORTED=yes
+		TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_ppc64.lo
+	fi
 	;;
   sparc*-*-linux*)
 	;;


	Jakub

  reply	other threads:[~2017-01-23 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170123113432epcas1p2951bfbb1968a143a14b9c54475ff3527@epcas1p2.samsung.com>
2017-01-23 11:34 ` Jakub Jelinek
2017-01-23 12:54   ` Maxim Ostapenko
2017-01-23 14:22     ` Bill Schmidt
2017-01-23 14:32       ` Jakub Jelinek [this message]
2017-01-23 14:41         ` Bill Schmidt
2017-01-23 15:10           ` Ulrich Weigand
2017-01-23 15:27             ` Jakub Jelinek
2017-01-23 14:44         ` Bill Schmidt
2017-01-23 14:47           ` Jakub Jelinek
2017-01-23 14:48             ` Bill Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123143246.GN1867@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc@gcc.gnu.org \
    --cc=m.ostapenko@samsung.com \
    --cc=wschmidt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).