From: Marek Polacek <polacek@redhat.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: Toon Moene <toon@moene.org>,
Steve Kargl <sgk@troutmask.apl.washington.edu>,
Markus Trippelsdorf <markus@trippelsdorf.de>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Jerry DeLisle <jvdelisle@charter.net>,
gfortran <fortran@gcc.gnu.org>,
GCC Development <gcc@gcc.gnu.org>
Subject: Re: Warning annoyances in list_read.c
Date: Mon, 27 Mar 2017 18:22:00 -0000 [thread overview]
Message-ID: <20170327182216.GN3172@redhat.com> (raw)
In-Reply-To: <0df02130-7939-a13e-a6c0-cdfee7d0141d@netcologne.de>
On Mon, Mar 27, 2017 at 07:59:01PM +0200, Thomas Koenig wrote:
> Am 27.03.2017 um 19:41 schrieb Marek Polacek:
>
> > Of course "the person" had bootstrapped and tested all the languages before
> > adding the warning. If only any of you bothered to check the fortran/
> > ChangeLogs:
>
> The problem is with libfortran, which apparently was not tested
> (or the problem would have been found and, presumably, dealt with).
I always build libgfortran when testing. The warning was committed
months ago, so it's weird that I'm only hearing about this now.
I would've been happy to fix the warnings if anyone pointed out them to me.
I hadn't know of them until very recently.
> So, due to incomplete testing, a regression was caused. This has
> probably happened a few thousand times before, so it is not an
> exceptionally big deal.
>
> We should deal with this the same way we deal with other regressions -
> fix it or, if anything else fails, roll back the offending patch.
> The person who is responsible for the regression should usually take the
> lead in fixing it.
>
> Since the fix appears to be rather trivial, I promise to review
> any patch that falls into my area of review (fortran, libfortran)
> within 48 hours.
https://gcc.gnu.org/ml/gcc/2017-03/msg00145.html
Marek
next prev parent reply other threads:[~2017-03-27 18:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eb8fcb55-8ad5-dbf3-8a2e-91911bc3c752@charter.net>
[not found] ` <20170326184534.GA18723@troutmask.apl.washington.edu>
2017-03-27 1:45 ` Jerry DeLisle
2017-03-27 2:31 ` Steve Kargl
2017-03-27 6:58 ` Markus Trippelsdorf
2017-03-27 13:26 ` Steve Kargl
2017-03-27 13:36 ` Jonathan Wakely
2017-03-27 13:50 ` Steve Kargl
2017-03-27 15:06 ` Jonathan Wakely
2017-03-27 15:10 ` Jonathan Wakely
2017-03-27 15:22 ` Markus Trippelsdorf
2017-03-27 16:27 ` Steve Kargl
2017-03-27 16:45 ` Marek Polacek
2017-03-27 17:26 ` Steve Kargl
2017-03-27 17:33 ` Toon Moene
2017-03-27 17:41 ` Marek Polacek
2017-03-27 17:59 ` Thomas Koenig
2017-03-27 18:21 ` Jonathan Wakely
2017-03-27 18:21 ` Richard Biener
2017-03-27 18:22 ` Marek Polacek [this message]
2017-03-27 18:16 ` Steve Kargl
2017-03-27 18:29 ` Marek Polacek
2017-03-27 18:55 ` Toon Moene
2017-03-27 13:39 ` Markus Trippelsdorf
2017-03-27 14:44 ` Steve Kargl
2017-03-27 15:04 ` Markus Trippelsdorf
2017-03-27 10:18 Dominique d'Humières
2017-03-27 14:53 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327182216.GN3172@redhat.com \
--to=polacek@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jvdelisle@charter.net \
--cc=jwakely.gcc@gmail.com \
--cc=markus@trippelsdorf.de \
--cc=sgk@troutmask.apl.washington.edu \
--cc=tkoenig@netcologne.de \
--cc=toon@moene.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).