From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53329 invoked by alias); 27 Mar 2017 18:22:24 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 53252 invoked by uid 89); 27 Mar 2017 18:22:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=wouldve, would've, H*MI:sk:0df0213, thousand X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Mar 2017 18:22:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7B4C2C07F69D; Mon, 27 Mar 2017 18:22:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7B4C2C07F69D Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=polacek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7B4C2C07F69D Received: from redhat.com (ovpn-204-247.brq.redhat.com [10.40.204.247]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2RIMHnC020357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 27 Mar 2017 14:22:19 -0400 Date: Mon, 27 Mar 2017 18:22:00 -0000 From: Marek Polacek To: Thomas Koenig Cc: Toon Moene , Steve Kargl , Markus Trippelsdorf , Jonathan Wakely , Jerry DeLisle , gfortran , GCC Development Subject: Re: Warning annoyances in list_read.c Message-ID: <20170327182216.GN3172@redhat.com> References: <20170327065843.GA294@x4> <20170327132605.GB24312@troutmask.apl.washington.edu> <20170327134956.GA24643@troutmask.apl.washington.edu> <20170327152212.GD294@x4> <20170327162734.GA25559@troutmask.apl.washington.edu> <20170327164532.GH3172@redhat.com> <20170327174112.GK3172@redhat.com> <0df02130-7939-a13e-a6c0-cdfee7d0141d@netcologne.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0df02130-7939-a13e-a6c0-cdfee7d0141d@netcologne.de> User-Agent: Mutt/1.7.1 (2016-10-04) X-SW-Source: 2017-03/txt/msg00172.txt.bz2 On Mon, Mar 27, 2017 at 07:59:01PM +0200, Thomas Koenig wrote: > Am 27.03.2017 um 19:41 schrieb Marek Polacek: > > > Of course "the person" had bootstrapped and tested all the languages before > > adding the warning. If only any of you bothered to check the fortran/ > > ChangeLogs: > > The problem is with libfortran, which apparently was not tested > (or the problem would have been found and, presumably, dealt with). I always build libgfortran when testing. The warning was committed months ago, so it's weird that I'm only hearing about this now. I would've been happy to fix the warnings if anyone pointed out them to me. I hadn't know of them until very recently. > So, due to incomplete testing, a regression was caused. This has > probably happened a few thousand times before, so it is not an > exceptionally big deal. > > We should deal with this the same way we deal with other regressions - > fix it or, if anything else fails, roll back the offending patch. > The person who is responsible for the regression should usually take the > lead in fixing it. > > Since the fix appears to be rather trivial, I promise to review > any patch that falls into my area of review (fortran, libfortran) > within 48 hours. https://gcc.gnu.org/ml/gcc/2017-03/msg00145.html Marek