Re: Improve syntax error

[Segher Boessenkool <segher@kernel.crashing.org>]

On Sat, Jan 05, 2019 at 06:02:08PM +0100, Daniel Marjamäki wrote:
> > I think the indentation warnings should catch that?
> 
> I get this:
> 
> void f()
> {
>   }
> } // <- error: expected identifier or '(' before '}' token
> 
> I ran with -Wall -Wextra -pedantic and did not see a indentation
> warning. Am I missing some indentation warning? The error message I
> get is a little misplaced. I think it's fine to warn about that } but
> it could also say in the error message that the problem is probably
> the previous }

I opened https://gcc.gnu.org/PR88790 .

> 
> > Should this say something like "expected ) or , or ;"?
> 
> No none of those suggestions will solve the error.
> 
> Look at this code:
> 
>     int x = 3) + 0;
> 
> Writing a ) or , or ; will not fix the syntax error. You have to
> remove the ) or add a ( somewhere.

Yeah, I wasn't quite awake when I wrote that, apparently :-)


Segher