From: Jan Hubicka <hubicka@ucw.cz>
To: Iain Sandoe <idsandoe@googlemail.com>
Cc: "Jason Merrill" <jason@redhat.com>,
"Martin Liška" <mliska@suse.cz>,
"Jonathan Wakely" <jwakely.gcc@gmail.com>,
"Richard Biener" <richard.guenther@gmail.com>,
"Jakub Jelinek" <jakub@redhat.com>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
"David Edelsohn" <dje.gcc@gmail.com>,
"GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Deprecate -frepo option.
Date: Thu, 27 Jun 2019 18:41:00 -0000 [thread overview]
Message-ID: <20190627184113.bieoglmjbgboydhr@kam.mff.cuni.cz> (raw)
In-Reply-To: <CB71AC7C-17B5-42E5-A6F1-3725176717C6@googlemail.com>
>
> > On 27 Jun 2019, at 19:21, Jan Hubicka <hubicka@ucw.cz> wrote:
> >
> >>
> >> It's useful on targets without COMDAT support. Are there any such
> >> that we care about at this point?
> >>
> >> If the problem is the combination with LTO, why not just prohibit that?
> >
> > The problem is that at the collect2 time we want to decide whether to
> > hold stderr/stdout of the linker. The issue is that we do not know yet
> > if we are going to LTO (because that is decided by linker plugin) or
> > whether we do repo files (because we look for those only after linker
> > failure).
>
> you could pre-scan for LTO, as is done for the collect2+non-plugin linker.
> (similar to the comment below, that would take some time, but probably
> small c.f the actual link).
the collect2+non-plugin does not handle static archives so it would need
more work while I think we should kill that code (and make darwin to use
lld)
Honza
> Iain
>
> > We can look for repo files first but that could take some time
> > especially for large programs (probably not too bad compared to actual
> > linking later) or we may require -frepo to be passed to collect2.
> >
> > Honza
> >>
> >> Jason
>
next prev parent reply other threads:[~2019-06-27 18:41 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:05 Dropping support of repo files (tlink) Martin Liška
2019-06-20 14:21 ` David Edelsohn
2019-06-20 14:27 ` Iain Sandoe
2019-06-20 15:10 ` Martin Liška
2019-06-20 19:53 ` Richard Biener
2019-06-21 10:22 ` Martin Liška
2019-06-21 10:28 ` Jonathan Wakely
2019-06-21 10:35 ` Iain Sandoe
2019-06-21 10:40 ` Martin Liška
2019-06-21 11:47 ` Jonathan Wakely
2019-06-21 11:52 ` [PATCH] Deprecate -frepo option Martin Liška
2019-06-21 11:59 ` Jakub Jelinek
2019-06-21 14:04 ` Martin Liška
2019-06-21 14:13 ` Jakub Jelinek
2019-06-21 14:28 ` Richard Biener
2019-06-27 12:30 ` Martin Liška
2019-06-27 12:58 ` Jonathan Wakely
2019-06-27 14:22 ` Martin Liška
2019-06-27 17:53 ` Jason Merrill
2019-06-27 18:21 ` Jan Hubicka
2019-06-27 18:32 ` Iain Sandoe
2019-06-27 18:41 ` Jan Hubicka [this message]
2019-07-08 12:04 ` Martin Liška
2019-07-09 10:39 ` Richard Biener
2019-07-09 11:41 ` Nathan Sidwell
2019-07-09 13:01 ` Martin Liška
2019-07-09 17:48 ` Nathan Sidwell
2019-07-09 21:14 ` Jason Merrill
2019-07-10 11:28 ` Martin Liška
2019-07-10 12:48 ` Nathan Sidwell
2019-07-10 12:53 ` Martin Liška
2019-07-10 12:56 ` Nathan Sidwell
2019-07-10 12:58 ` Jakub Jelinek
2019-07-11 6:48 ` [PATCH] Deprecate -frepo on gcc-9 branch (PR c++/91125) Martin Liška
2019-07-11 7:02 ` Jakub Jelinek
2019-07-11 17:26 ` Jason Merrill
2019-07-12 12:44 ` Martin Liška
2019-07-12 14:25 ` Jason Merrill
2019-09-04 8:13 ` [PATCH] Deprecate -frepo option Martin Liška
2019-09-04 9:22 ` Jonathan Wakely
2019-09-04 11:20 ` Martin Liška
2019-09-04 12:57 ` Nathan Sidwell
2019-09-05 10:01 ` Richard Biener
2019-09-05 10:03 ` Martin Liška
2019-09-05 11:02 ` Nathan Sidwell
2019-09-05 11:09 ` Richard Biener
2019-09-05 11:22 ` Martin Liška
2019-09-05 12:06 ` Jonathan Wakely
2019-09-05 12:31 ` Richard Biener
2019-09-05 12:51 ` Martin Liška
2019-09-06 6:58 ` Martin Liška
2019-09-06 14:48 ` Marek Polacek
2019-09-06 14:56 ` Jakub Jelinek
2019-09-06 16:03 ` Martin Liška
2019-09-09 11:02 ` Martin Liška
2019-09-09 11:08 ` Jakub Jelinek
2019-09-09 11:25 ` [PATCH] Update comment of removed options Martin Liška
2019-09-09 11:35 ` Jonathan Wakely
2019-09-09 12:44 ` Theodore Papadopoulo
2019-09-09 11:39 ` Jakub Jelinek
2019-09-09 11:46 ` Martin Liška
2019-06-21 11:50 ` Dropping support of repo files (tlink) Iain Sandoe
2019-06-21 12:37 ` Richard Biener
2019-06-21 12:50 ` Jan Hubicka
2019-06-21 13:08 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627184113.bieoglmjbgboydhr@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=idsandoe@googlemail.com \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).