From: Arvind Sankar <nivedita@alum.mit.edu>
To: Michael Matz <matz@suse.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>, gcc@gcc.gnu.org
Subject: Re: Use predicates for RTL objects
Date: Thu, 08 Aug 2019 17:12:00 -0000 [thread overview]
Message-ID: <20190808171232.GA1619488@rani.riverdale.lan> (raw)
In-Reply-To: <alpine.LSU.2.21.1908081453370.25869@wotan.suse.de>
On Thu, Aug 08, 2019 at 03:04:53PM +0000, Michael Matz wrote:
> Hi,
>
> On Wed, 7 Aug 2019, Arvind Sankar wrote:
>
> > => x->is_a (REG)
>
> Oh god, please no. Currently at least the RTL parts of GCC still have
> mostly a consistent and obvious style, which is a good thing. I have no
> idea why anyone would think the above is easier to read than REG_P (x).
>
>
> Ciao,
> Michael.
> P.S: Consider this: the current style served us quite well for the last 35
> or so years, so before suggesting style changes, shouldn't you first work
> on the sources for some time?
Well, the main point of the email was to ask for review of a patchset
that attempts to make progress on a TODO that has been outstanding for
at least 15 of those 35 years.
next prev parent reply other threads:[~2019-08-08 17:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 16:15 Arvind Sankar
2019-08-07 17:33 ` Segher Boessenkool
2019-08-07 17:40 ` Arvind Sankar
2019-08-07 18:05 ` Segher Boessenkool
2019-08-07 18:58 ` Arvind Sankar
2019-08-08 15:04 ` Segher Boessenkool
2019-08-08 17:42 ` Arvind Sankar
2019-08-08 18:26 ` Segher Boessenkool
2019-08-08 18:53 ` Arvind Sankar
2019-08-08 20:28 ` Jeff Law
2019-08-08 9:10 ` Richard Sandiford
2019-08-08 15:28 ` Segher Boessenkool
2019-08-08 14:31 ` Jeff Law
2019-08-08 15:36 ` Segher Boessenkool
2019-08-08 17:07 ` Arvind Sankar
2019-08-08 20:11 ` Jeff Law
2019-08-09 8:06 ` Richard Biener
2019-08-08 15:04 ` Michael Matz
2019-08-08 17:12 ` Arvind Sankar [this message]
2019-08-08 18:14 ` Jakub Jelinek
2019-08-08 18:35 ` Arvind Sankar
2019-08-08 18:46 ` Jakub Jelinek
2019-08-08 20:32 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2006-02-03 4:23 nathan bullock
2006-02-03 5:46 ` Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808171232.GA1619488@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=gcc@gcc.gnu.org \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).