From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118550 invoked by alias); 8 Aug 2019 18:35:33 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 118541 invoked by uid 89); 8 Aug 2019 18:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=HX-Google-DKIM-Signature:sender, PS, P.S, UD:P.S X-HELO: mail-qk1-f176.google.com Received: from mail-qk1-f176.google.com (HELO mail-qk1-f176.google.com) (209.85.222.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Aug 2019 18:35:31 +0000 Received: by mail-qk1-f176.google.com with SMTP id r21so69709641qke.2 for ; Thu, 08 Aug 2019 11:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NC1TITv8N2pox12IsHDLD/gvLvVAVLxrBe091GSgoDo=; b=GE/LDATibI3toC89wGqgHVV+1Mw3GyNxqxFGMw0Za2Ero4z9kKzHlXE+A7mooU5fA7 CMm+3s0MW4PdulKvUM1BQ/+zk+I3ygBo+FoDLfYQxc3J9amnTKgJw98JIeY+gZ8xEniH fYmJHE51kXrtx4D96A+6vwIVNRSEP+r8WmMEyipvNO+91iiFxw6FNZyiskl9yvs2BLu5 E6U8f58O9CMfBzWpB5SfICyKK2px5L0HzH5LZfDaSYwvI6J4dshYP8lvVKq42rqI0iA3 UpbM2kiZVhQZDwBLbdgVG6+ArPI00D2QbpbcrSmC1TTNT+aJulUbqhM3AOb1ZVbkgSux hnpw== Return-Path: Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id z5sm39430966qti.80.2019.08.08.11.35.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Aug 2019 11:35:28 -0700 (PDT) From: Arvind Sankar Date: Thu, 08 Aug 2019 18:35:00 -0000 To: Jakub Jelinek Cc: Arvind Sankar , Michael Matz , gcc@gcc.gnu.org Subject: Re: Use predicates for RTL objects Message-ID: <20190808183526.GA1651713@rani.riverdale.lan> References: <20190807161528.GA3326377@rani.riverdale.lan> <20190808171232.GA1619488@rani.riverdale.lan> <20190808181401.GT2726@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190808181401.GT2726@tucnak> User-Agent: Mutt/1.10.1 (2018-07-13) X-SW-Source: 2019-08/txt/msg00051.txt.bz2 On Thu, Aug 08, 2019 at 08:14:01PM +0200, Jakub Jelinek wrote: > On Thu, Aug 08, 2019 at 01:12:33PM -0400, Arvind Sankar wrote: > > On Thu, Aug 08, 2019 at 03:04:53PM +0000, Michael Matz wrote: > > > Hi, > > > > > > On Wed, 7 Aug 2019, Arvind Sankar wrote: > > > > > > > => x->is_a (REG) > > > > > > Oh god, please no. Currently at least the RTL parts of GCC still have > > > mostly a consistent and obvious style, which is a good thing. I have no > > > idea why anyone would think the above is easier to read than REG_P (x). > > > > > > > > > Ciao, > > > Michael. > > > P.S: Consider this: the current style served us quite well for the last 35 > > > or so years, so before suggesting style changes, shouldn't you first work > > > on the sources for some time? > > > > Well, the main point of the email was to ask for review of a patchset > > that attempts to make progress on a TODO that has been outstanding for > > at least 15 of those 35 years. > > Not everything that is in some TODO list somewhere is something generally > agreed upon. > > Jakub Surely there's general agreement on using REG_P etc? I don't see anyone objecting to it, and that's all the patchset does: to avoid any confusion the second half of the email asking about opinions on is_a is entirely independent from the first half describing the existing patchset.