From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121222 invoked by alias); 10 Aug 2019 17:06:40 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 121205 invoked by uid 89); 10 Aug 2019 17:06:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1350, cool, you! X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Aug 2019 17:06:39 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x7AH6Vss001750; Sat, 10 Aug 2019 12:06:31 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x7AH6U3u001749; Sat, 10 Aug 2019 12:06:30 -0500 Date: Sat, 10 Aug 2019 17:06:00 -0000 From: Segher Boessenkool To: Jakub Jelinek Cc: Hans-Peter Nilsson , Richard Biener , gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org, amodra@gmail.com, joern.rennecke@riscy-ip.com Subject: Re: Using gcc/ChangeLog instead of gcc/testsuite/ChangeLog? Message-ID: <20190810170629.GU31406@gate.crashing.org> References: <201908100653.x7A6rjhE015519@ignucius.se.axis.com> <20190810101246.GG2726@tucnak> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190810101246.GG2726@tucnak> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00082.txt.bz2 Hi! On Sat, Aug 10, 2019 at 12:12:46PM +0200, Jakub Jelinek wrote: > On Sat, Aug 10, 2019 at 08:53:45AM +0200, Hans-Peter Nilsson wrote: > > Has there been a change of policy so it's a valid option to use > > gcc/ChangeLog for testsuite changes? I was about to move a > > semi-randomly spotted misplaced entry, and when checking if > > there were others, I noticed that there's like tens of them, so > > I thought better ask. > > Nothing in the policy changed. While we have mklog that helps with the job, > it is still mostly hand written stuff and people make occassionally > mistakes, that can happen to anyone. Admittedly some people repeat those > mistakes often. It's why I started doing those gcc/testsuite/ things in the changelogs in the patches I send, to remind me what file to apply what to. It helps :-) > I ran the gcc/ subdirectory ChangeLogs through following script that doesn't > seem to have false positives ATM and highlights some common mistakes people > make and fixed them, see patch below. Cool, thank you! > Another common mistake is more than 2 newline characters in sequence. Git goes as far as not allowing it in a log message (with standard configurations, with the standard frontend tools). Drives me nuts, I use it for formatting all the time. Segher