From: Segher Boessenkool <segher@kernel.crashing.org>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: Adding -Wshadow=local to gcc build rules
Date: Sat, 21 Sep 2019 09:44:00 -0000 [thread overview]
Message-ID: <20190921094448.GX9749@gate.crashing.org> (raw)
In-Reply-To: <AM6PR10MB256682838C777B5C8828C4BEE48E0@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM>
Hi!
On Wed, Sep 18, 2019 at 01:08:50PM +0000, Bernd Edlinger wrote:
> I'm currently trying to add -Wshadow=local to the gcc build rules.
> I started with -Wshadow, but gave up that idea immediately.
>
> As you could expect the current code base has plenty of shadowed
> local variables. Most are trivial to resolve, some are less trivial.
> I am not finished yet, but it is clear that it will be a rather big
> patch.
It shouldn't be a big patch. It should be a biggish collection of small
patches, most of which are trivial and obvious and you can just commit
without further approval!
Segher
next prev parent reply other threads:[~2019-09-21 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 13:08 Bernd Edlinger
2019-09-18 13:39 ` Martin Liška
2019-09-18 15:16 ` Tom Tromey
2019-09-19 10:20 ` Richard Biener
2019-09-20 18:20 ` Bernd Edlinger
2019-09-20 19:13 ` Jason Merrill
2019-09-21 9:44 ` Segher Boessenkool [this message]
2019-10-02 19:10 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921094448.GX9749@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).