From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46586 invoked by alias); 21 Sep 2019 09:44:52 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 46578 invoked by uid 89); 21 Sep 2019 09:44:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Sep 2019 09:44:51 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x8L9iniO013194; Sat, 21 Sep 2019 04:44:49 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x8L9im4h013193; Sat, 21 Sep 2019 04:44:48 -0500 Date: Sat, 21 Sep 2019 09:44:00 -0000 From: Segher Boessenkool To: Bernd Edlinger Cc: "gcc@gcc.gnu.org" Subject: Re: Adding -Wshadow=local to gcc build rules Message-ID: <20190921094448.GX9749@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00175.txt.bz2 Hi! On Wed, Sep 18, 2019 at 01:08:50PM +0000, Bernd Edlinger wrote: > I'm currently trying to add -Wshadow=local to the gcc build rules. > I started with -Wshadow, but gave up that idea immediately. > > As you could expect the current code base has plenty of shadowed > local variables. Most are trivial to resolve, some are less trivial. > I am not finished yet, but it is clear that it will be a rather big > patch. It shouldn't be a big patch. It should be a biggish collection of small patches, most of which are trivial and obvious and you can just commit without further approval! Segher