From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75235 invoked by alias); 14 Jan 2020 10:29:22 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 75218 invoked by uid 89); 14 Jan 2020 10:29:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2020 10:29:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578997750; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wMawcERkcabZsgy19Yi+h70S5gOJwOgF0xRPzzzLgig=; b=iVrwztrO9pCbMssfaI7Kqc53cHuOUejObPRdt6ZxdCA0gdUcNKK2HzEcXwQvUz9YxV9ukQ 8hVNNtCcIJFcv6RB1J+qRmvVeqtVnkUPZlmj7E6ueW4K+3muRYAkodSN/ADc0g5+rYW7aE 2E2tAqIGq/rmJROfOafbhtJUkP6vMhM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-RAzhnTBdPbyMieF1lpuuSw-1; Tue, 14 Jan 2020 05:29:07 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C21C100550E; Tue, 14 Jan 2020 10:29:06 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-74.brq.redhat.com [10.40.204.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 823B910842A9; Tue, 14 Jan 2020 10:29:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 00EAT3lQ000392; Tue, 14 Jan 2020 11:29:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 00EAT2vE000391; Tue, 14 Jan 2020 11:29:02 +0100 Date: Tue, 14 Jan 2020 11:01:00 -0000 From: Jakub Jelinek To: gcc@gcc.gnu.org Cc: Jason Merrill , "Joseph S. Myers" , "Richard Earnshaw (lists)" Subject: Whitespace at the start of first line of commit Message-ID: <20200114102902.GA10088@tucnak> Reply-To: Jakub Jelinek MIME-Version: 1.0 User-Agent: Mutt/1.11.3 (2019-02-01) X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00232.txt.bz2 Hi! I've noticed that a couple of Jason's commits show up in gcc-cvs in mutt as: [gcc r10-5937] ?PR c++/92582 - ICE with member template as requirement. The ? in there comes from a tab character, the full subject is like Subject: =3D?utf-8?q?=3D5Bgcc_r10-5937=3D5D_=3D09PR_c++/92582_-_ICE_with_me= mber_template_a?=3D =3D?utf-8?q?s_requirement=3D2E?=3D One possibility to deal with this is: --- hooks/updates/__init__.py 2020-01-12 22:30:37.143193572 +0100 +++ hooks/updates/__init__.py 2020-01-14 11:20:05.746749843 +0100 @@ -315,7 +315,7 @@ class AbstractUpdate(object): subject =3D '[%(repo)s%(branch)s] %(subject)s' % { 'repo': self.email_info.project_name, 'branch': branch, - 'subject': commit.subject[:SUBJECT_MAX_SUBJECT_CHARS], + 'subject': commit.subject[:SUBJECT_MAX_SUBJECT_CHARS].strip (), } =20 # Generate the body of the email in two pieces: (untested), another, suggested by Richard on IRC, would be to reject commits where the first line starts with whitespace. So, what do we want to do here? Jakub